Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new field to save customized message for validation #643

Merged
merged 1 commit into from
May 18, 2022

Conversation

akhilkr128
Copy link
Member

issue

Need a new field for saving the customized message.

@kbrock
Copy link
Member

kbrock commented May 16, 2022

@akhilkr128 does the request to rename the field make sense to you?

@akhilkr128 akhilkr128 force-pushed the add_regex_message_field branch from 16953aa to 78498fd Compare May 17, 2022 12:44
@miq-bot
Copy link
Member

miq-bot commented May 17, 2022

Checked commit akhilkr128@78498fd with ruby 2.6.9, rubocop 1.19.1, haml-lint 0.35.0, and yamllint
1 file checked, 0 offenses detected
Everything looks fine. 🍪

@akhilkr128
Copy link
Member Author

@akhilkr128 does the request to rename the field make sense to you?

Completely understood what @jrafanie said. Previously in the UI there was a term failed I removed it later because the form won't be submitted and technically it won't fail. This message will notify the user instantly to help the user input data. I think the field name change is not needed. The current UI will look like this.

But if you guys think this field name change will increase code readability please let me know, I will make the changes.

@kbrock kbrock merged commit a4ee0a9 into ManageIQ:master May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants