Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewriting PXE Customization Template Form to React #7622

Merged
merged 1 commit into from
Mar 24, 2021
Merged

Rewriting PXE Customization Template Form to React #7622

merged 1 commit into from
Mar 24, 2021

Conversation

DavidResende0
Copy link
Member

Form can be found in Compute->Infrastructure->PXE

Fixes: #6854
API: ManageIQ/manageiq-api#981

@miq-bot miq-bot added the wip label Feb 8, 2021
@DavidResende0
Copy link
Member Author

@skateman

@DavidResende0 DavidResende0 force-pushed the react-pxe-customization-template branch from 0fe8826 to 3b07d31 Compare February 9, 2021 19:30
@DavidResende0 DavidResende0 force-pushed the react-pxe-customization-template branch from 2cb3c75 to 1fabf16 Compare February 12, 2021 19:33
@DavidResende0 DavidResende0 force-pushed the react-pxe-customization-template branch from 1fabf16 to f380ae6 Compare February 16, 2021 15:44
@DavidResende0 DavidResende0 force-pushed the react-pxe-customization-template branch 6 times, most recently from 6c647f3 to 6fdc244 Compare March 2, 2021 18:14
@miq-bot
Copy link
Member

miq-bot commented Mar 2, 2021

Checked commit DavidResende0@6fdc244 with ruby 2.6.3, rubocop 0.82.0, haml-lint 0.35.0, and yamllint
6 files checked, 1 offense detected

**

  • 💣 💥 🔥 🚒 - Linter/Haml - Linter::Haml STDERR:
warning: parser/current is loading parser/ruby26, which recognizes
warning: 2.6.6-compliant syntax, but you are running 2.6.3.
warning: please see https://github.com/whitequark/parser#compatibility-with-ruby-mri.

@DavidResende0 DavidResende0 changed the title [WIP] Rewriting PXE Customization Template Form to React Rewriting PXE Customization Template Form to React Mar 2, 2021
@miq-bot miq-bot removed the wip label Mar 2, 2021
@DavidResende0 DavidResende0 force-pushed the react-pxe-customization-template branch 2 times, most recently from 17432df to 067c892 Compare March 16, 2021 18:06
@DavidResende0 DavidResende0 force-pushed the react-pxe-customization-template branch from 067c892 to 06e4183 Compare March 17, 2021 17:48
@DavidResende0 DavidResende0 force-pushed the react-pxe-customization-template branch from 06e4183 to b7a27ed Compare March 17, 2021 19:22
@h-kataria h-kataria merged commit 87d796f into ManageIQ:master Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skateman skateman skateman requested changes

@h-kataria h-kataria h-kataria approved these changes

Assignees

@h-kataria h-kataria

Labels
refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Form conversion: Compute/Infrastructure/pxe customizaton templates add/edit
5 participants
@DavidResende0 @miq-bot @skateman @h-kataria @Fryguy