Convert the subnet form to DDF

[DavidResende0]

Continuation of: #7632

Resolves: #6861
Depends On: ManageIQ/manageiq-providers-openstack#712

Before:

After:

[DavidResende0]

This is needed since these fields are coming from the provider. There's also a chance that other providers may need similar treatment but I can't test those at the moment.

[DavidResende0]

Both of these changes are to alter the values being submitted by the form so that the cloud subnet is created correctly (renaming dchp_enabled to enabled_dhcp and removing the extra_attributes object while moving its contents back directly into values).

The alternative to this is to change the form schema in the provider and the API to match what the back-end is expecting.

[DavidResende0]

@miq-bot assign @kavyanekkalapu
@miq-bot add_reviewer @kavyanekkalapu , @Fryguy
@agrare

As far as I can tell the form seems to be working now, but I haven't been able to test the form with any non-openstack providers so there could be issues there.

I also left a couple of comments in different areas where I'm not thrilled with the solutions and I was hoping someone could take a look and maybe suggest alternatives, in particular ways that some of these changes could happen in the provider repos

[kavyanekkalapu]

@DavidResende0 i checked functionality, it is working as expected, found one minor issue, edit form is loading slow, has delay of approximately 5 sec, it is just showing blank page until that time, it would be nice to show loading symbol until data is loaded.., please check if that is possible.

[DavidResende0]

@kavyanekkalapu, I looked into the loading issue for the edit form and I haven't been able to reproduce it but if I wanted to add a loading symbol, what would I do.

[miq-bot]

Checked commit DavidResende0@9f53567 with ruby 2.6.3, rubocop 1.13.0, haml-lint 0.35.0, and yamllint
5 files checked, 2 offenses detected

app/views/cloud_subnet/edit.html.haml

• ⚠️ - Line 2 - Layout/TrailingEmptyLines: Final newline missing.

app/views/cloud_subnet/new.html.haml

• ⚠️ - Line 2 - Layout/TrailingEmptyLines: Final newline missing.

[Fryguy]

@DavidResende0 A conflict occurred during the backport of this pull request to morphy.

If this pull request is based on another pull request that has not been marked for backport, add the appropriate labels to the other pull request. Otherwise, please create a new pull request direct to the morphy branch in order to resolve this.

Conflict details:

diff --cc app/javascript/packs/component-definitions-common.js
index e5a2d8456d,018ff163d7..0000000000
--- a/app/javascript/packs/component-definitions-common.js
+++ b/app/javascript/packs/component-definitions-common.js
@@@ -41,8 -46,10 +41,9 @@@ import ReportChartWidget from '../compo
  import ReportDataTable from '../components/report-data-table';
  import RetirementForm from '../components/retirement-form';
  import ServiceDialogFromForm from '../components/service-dialog-from-form/service-dialog-from';
+ import SubnetForm from '../components/subnet-form';
  import EditServiceForm from '../components/edit-service-form';
  import SetOwnershipForm from '../components/set-ownership-form';
 -import ServersDataChart from '../components/provider-dashboard-charts/servers-pie-chart';
  import TableListViewWrapper from '../react/table_list_view_wrapper';
  import TaggingWrapperConnected from '../components/taggingWrapper';
  import { TagView } from '../tagging';
@@@ -104,6 -119,8 +105,11 @@@ ManageIQ.component.addReact('Retirement
  ManageIQ.component.addReact('ServiceDialogFromForm', ServiceDialogFromForm);
  ManageIQ.component.addReact('EditServiceForm', EditServiceForm);
  ManageIQ.component.addReact('SetOwnershipForm', SetOwnershipForm);
++<<<<<<< HEAD
++=======
+ ManageIQ.component.addReact('ServersDataChart', ServersDataChart);
+ ManageIQ.component.addReact('SubnetForm', SubnetForm);
++>>>>>>> 745801e296... Merge pull request #7734 from DavidResende0/react-cloud-subnet
  ManageIQ.component.addReact('TableListView', TableListView);
  ManageIQ.component.addReact('TableListViewWrapper', TableListViewWrapper);
  ManageIQ.component.addReact('TagGroup', props => <TagGroup {...props} />);

[Fryguy]

Backported to morphy

commit afcb1947b3465960c355093d8bb1d6b3fcc36ac8 (HEAD -> morphy, upstream/morphy)
Author: Kavya Nekkalapu <37085529+kavyanekkalapu@users.noreply.github.com>
Date:   Fri May 21 11:15:35 2021 -0400

    Merge pull request #7734 from DavidResende0/react-cloud-subnet

    Convert the subnet form to DDF

    (cherry picked from commit 745801e2963ea5a3a2ac83da7279ad3d945c69c3)