Convert router interface forms #7969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GilbertCherrie
force-pushed
the
convert_router_interface_forms
branch
2 times, most recently
from
fb3a12a to
37eace4
Compare
GilbertCherrie
force-pushed
the
convert_router_interface_forms
branch
3 times, most recently
from
13a0498 to
1fe11b0
Compare
GilbertCherrie
changed the title
|
@miq-bot add_reviewer @kavyanekkalapu |
GilbertCherrie
force-pushed
the
convert_router_interface_forms
branch
from
9a7dc2e to
4bc3b34
Compare
GilbertCherrie
force-pushed
the
convert_router_interface_forms
branch
2 times, most recently
from
a1be47f to
9610457
Compare
kavyanekkalapu
approved these changes
Dec 7, 2021
GilbertCherrie
force-pushed
the
convert_router_interface_forms
branch
from
9610457 to
7fc7a65
Compare
jeffibm
approved these changes
Dec 9, 2021
GilbertCherrie
force-pushed
the
convert_router_interface_forms
branch
from
7fc7a65 to
4feef38
Compare
GilbertCherrie
force-pushed
the
convert_router_interface_forms
branch
from
4feef38 to
1c85933
Compare
|
Checked commit GilbertCherrie@1c85933 with ruby 2.6.3, rubocop 1.13.0, haml-lint 0.35.0, and yamllint app/views/network_router/add_interface_select.html.haml
app/views/network_router/remove_interface_select.html.haml
|
kavyanekkalapu
approved these changes
Dec 9, 2021
kavyanekkalapu
approved these changes
Dec 9, 2021
33 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7987
Converted old forms to Carbon React and combined the add and remove interface forms into a single form.
Blocked by apis for adding and removing interfaces.
Before:
After:
