-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Timeline Conversion #8496
Timeline Conversion #8496
Conversation
6c61e14
to
13d33b7
Compare
@MelsHyrule Should this be WIP since you have some additional TODO's in the OP? |
@Fryguy the first 2 todos are more notes of things that can be done in the future to enhance this form overall (with the first todo being more a todo this in a seperate PR reminder). the third todo is something im gonna talk with the UI now so i guess i can move it back to WIP (especially since it just failed a jest test, whoops) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MelsHyrule, if the plan is to merge this and then work on the actual timeline in a separate pr then everything LGTM
@DavidResende0 yes the timeline and tables that come with it will be converted in a future PR, this PR focuses on converting https://github.com/ManageIQ/manageiq-ui-classic/blob/master/app/views/layouts/_tl_options.html.haml#L113 this file per this issue #7603 |
@vfebvre Does the databump you gave me have any Policy Event data? |
a21fc9e
to
78ca391
Compare
bdd2aca
to
07c32fe
Compare
Checked commit MelsHyrule@07c32fe with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint app/views/layouts/_tl_show.html.haml
|
Part of #7603
BEFORE
AFTER
Future Work: