Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeline Conversion #8496

Merged
merged 1 commit into from
Nov 1, 2022
Merged

Conversation

MelsHyrule
Copy link
Member

@MelsHyrule MelsHyrule commented Oct 26, 2022

Part of #7603

BEFORE

Screen Shot 2022-10-26 at 5 34 39 PM

Screen Shot 2022-10-26 at 5 34 59 PM

AFTER

Screen Shot 2022-10-26 at 5 03 17 PM

Screen Shot 2022-10-26 at 5 03 38 PM

Future Work:

@MelsHyrule MelsHyrule requested a review from a team as a code owner October 26, 2022 20:51
@miq-bot miq-bot added the wip label Oct 26, 2022
@MelsHyrule MelsHyrule force-pushed the new-timeline-options branch from 6c61e14 to 13d33b7 Compare October 26, 2022 21:56
@MelsHyrule
Copy link
Member Author

@miq-bot add-reviewer @DavidResende0
@miq-bot add-reviewer @jeffibm
@miq-bot add-reviewer @GilbertCherrie
@miq-bot assign @jeffibm
@miq-bot add-label enhancement

cc @Fryguy @jrafanie @vfebvre

@MelsHyrule MelsHyrule changed the title [WIP] Timeline Conversion Timeline Conversion Oct 26, 2022
@miq-bot miq-bot added enhancement and removed wip labels Oct 26, 2022
@Fryguy
Copy link
Member

Fryguy commented Oct 26, 2022

@MelsHyrule Should this be WIP since you have some additional TODO's in the OP?

@MelsHyrule
Copy link
Member Author

@Fryguy the first 2 todos are more notes of things that can be done in the future to enhance this form overall (with the first todo being more a todo this in a seperate PR reminder). the third todo is something im gonna talk with the UI now so i guess i can move it back to WIP (especially since it just failed a jest test, whoops)

@MelsHyrule MelsHyrule changed the title Timeline Conversion [WIP] Timeline Conversion Oct 26, 2022
@miq-bot miq-bot added the wip label Oct 26, 2022
Copy link
Member

@DavidResende0 DavidResende0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MelsHyrule, if the plan is to merge this and then work on the actual timeline in a separate pr then everything LGTM

@MelsHyrule
Copy link
Member Author

@DavidResende0 yes the timeline and tables that come with it will be converted in a future PR, this PR focuses on converting https://github.com/ManageIQ/manageiq-ui-classic/blob/master/app/views/layouts/_tl_options.html.haml#L113 this file per this issue #7603

@MelsHyrule MelsHyrule changed the title [WIP] Timeline Conversion Timeline Conversion Oct 27, 2022
@miq-bot miq-bot removed the wip label Oct 27, 2022
@MelsHyrule
Copy link
Member Author

@vfebvre Does the databump you gave me have any Policy Event data?

@MelsHyrule MelsHyrule force-pushed the new-timeline-options branch 4 times, most recently from a21fc9e to 78ca391 Compare October 31, 2022 15:58
@MelsHyrule MelsHyrule force-pushed the new-timeline-options branch from bdd2aca to 07c32fe Compare October 31, 2022 16:13
@miq-bot
Copy link
Member

miq-bot commented Oct 31, 2022

Checked commit MelsHyrule@07c32fe with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint
2 files checked, 1 offense detected

app/views/layouts/_tl_show.html.haml

  • ⚠️ - Line 4 - Avoid using instance variables in partials views

@MelsHyrule
Copy link
Member Author

@miq-bot assign @Fryguy

Jason could we get your review on this PR too?

@Fryguy Fryguy merged commit 921a68b into ManageIQ:master Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants