-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove monitoring code #8783
Remove monitoring code #8783
Conversation
spec/config/routes.pending.yml
Outdated
AlertsListController: | ||
- class_icons | ||
- index | ||
- report_data | ||
AlertsMostRecentController: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@akhilkr128 Do you know what this is? Should it also be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe it is for the routing specs. These are getting fetched here and testing it. I have removed the routes and controllers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I wasn't clear. I understand how the routes.pending.yml file works. However, I was talking about specifically the entry for AlertsMostRecentController
, which is still present, but I would have expected that to be removed in this PR also.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I misunderstood the question, I will remove the AlertsMostRecentController
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made the changes.
c5f09f3
to
980eac8
Compare
Checked commit akhilkr128@980eac8 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint app/views/layouts/_center_div_no_listnav.html.haml
|
Part of #7603
Before
After
Links [Optional]