Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove monitoring code #8783

Merged
merged 1 commit into from
May 23, 2023
Merged

Conversation

akhilkr128
Copy link
Member

@akhilkr128 akhilkr128 requested a review from a team as a code owner May 9, 2023 12:42
AlertsListController:
- class_icons
- index
- report_data
AlertsMostRecentController:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akhilkr128 Do you know what this is? Should it also be removed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it is for the routing specs. These are getting fetched here and testing it. I have removed the routes and controllers.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I wasn't clear. I understand how the routes.pending.yml file works. However, I was talking about specifically the entry for AlertsMostRecentController, which is still present, but I would have expected that to be removed in this PR also.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I misunderstood the question, I will remove the AlertsMostRecentController.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made the changes.

@akhilkr128 akhilkr128 force-pushed the remove_alerts_angular branch from c5f09f3 to 980eac8 Compare May 16, 2023 06:53
@miq-bot
Copy link
Member

miq-bot commented May 16, 2023

Checked commit akhilkr128@980eac8 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint
5 files checked, 1 offense detected

app/views/layouts/_center_div_no_listnav.html.haml

  • ⚠️ - Line 11 - Avoid using instance variables in partials views

@Fryguy Fryguy merged commit 8ad03a7 into ManageIQ:master May 23, 2023
@Fryguy Fryguy assigned Fryguy and unassigned jeffibm May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants