Store wheel #15
Open
Store wheel #15
+181
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeorgWa
approved these changes
Jan 16, 2025
| If a pre-release of `X.Y.Z-dev0` is done, the next version number should be `X.Y.Z-dev1`. | ||
|
|
||
| (Note: if you want to build wheel from such a version, you need to substitute `-dev` with `.dev`, | ||
| to have e.g. `packaname-1.2.3.dev0-py3-none-any.whl`) | ||
| to have e.g. `packagename-1.2.3.dev0-py3-none-any.whl`) | ||
|
|
||
|
|
||
| ### Step-by-step instructions |
There was a problem hiding this comment.
Maybe add what we will do on a high level:
bump the version away from a dev version,
perform release,
Switch to dev
| if git show-ref --tags --verify --quiet "refs/tags/${TAG}"; then | ||
| echo "Tag ${TAG} exists, continuing .." | ||
| else | ||
| echo "Tag ${TAG} does not exist. Did you forget to publish the release?" |
There was a problem hiding this comment.
nope, this is related to me wondering why the checkout failed with a weird error message ;-)
| - name: Check package | ||
| run: | | ||
| pip install twine | ||
| twine check --strict ${{steps.prepare_wheel.outputs.WHEEL_FILE}} |
| run: | | ||
| # os-specific wheel creating takes precedence | ||
| if [ -f release/${{ inputs.os }}/build_wheel_${{ inputs.os }}.sh ]; then | ||
| echo "Building os-specific wheel" |
There was a problem hiding this comment.
Maybe add something like "Downloaded wheel will not be used"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allowing to build the wheel only once: prevent potentially different dependencies between installers & pip.
Here it is in action:
https://github.com/MannLabs/directlfq/actions/runs/12813629376
Here's resulting artifacts:
https://github.com/MannLabs/directlfq/releases/tag/untagged-98e7a0c8afbb7b580426
Version on test-pypi:
https://github.com/MannLabs/directlfq/actions/runs/12814576748/job/35731356979
https://test.pypi.org/project/directlfq/0.3.1.dev1/
These are the recommended changes to a repo (but it's backwards compatible):
https://github.com/MannLabs/directlfq/compare/improve_requirements...improve_release_workflow?expand=1