Merge pull request #791 from MarathonLabs/fix/ignore-failures

fix(cli): ignoreFailures should produce error if false
MarathonLabs · Apr 29, 2023 · 1365090 · 1365090
2 parents 182d46a + e7df9e5
commit 1365090
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/cli/src/main/kotlin/com/malinskiy/marathon/cli/ApplicationView.kt b/cli/src/main/kotlin/com/malinskiy/marathon/cli/ApplicationView.kt
@@ -84,10 +84,9 @@ private fun execute(cliConfiguration: CliConfiguration) {
             throw PrintMessage(message = "Marathon execution crashed", error = true)
         }
 
-        val shouldReportFailure = !configuration.ignoreFailures
         when {
             success -> throw PrintMessage(message = "Marathon execution finished", error = false)
-            shouldReportFailure -> throw PrintMessage(message = "Marathon execution finished with failures (Failures suppressed because ignoreFailures is `true`)", error = false)
+            configuration.ignoreFailures -> throw PrintMessage(message = "Marathon execution finished with failures (Failures suppressed because ignoreFailures is `true`)", error = false)
             else -> throw PrintMessage(message = "Marathon execution failed", error = true)
         }
     } finally {