fix(android_parsing): remote parse without overridden testrun listene… #876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r if a user forgot to add the correspondent dependency in the project
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/raw_json_meta_2 #876 +/- ##
==========================================================
Coverage 59.30% 59.30%
Complexity 798 798
==========================================================
Files 214 214
Lines 4443 4443
Branches 709 709
==========================================================
Hits 2635 2635
Misses 1476 1476
Partials 332 332 ☔ View full report in Codecov by Sentry. |
Malinskiy
requested changes
Dec 12, 2023
| @@ -68,7 +78,10 @@ class AmInstrumentTestParser( | |||
|
|
|||
| val testParserConfiguration = vendorConfiguration.testParserConfiguration | |||
| val overrides: Map<String, String> = when { | |||
| testParserConfiguration is TestParserConfiguration.RemoteTestParserConfiguration -> testParserConfiguration.instrumentationArgs | |||
| testParserConfiguration is TestParserConfiguration.RemoteTestParserConfiguration -> { | |||
| if (blockListenerArgumentOverride) testParserConfiguration.instrumentationArgs.filterKeys { it != LISTENER_ARGUMENT } | |||
There was a problem hiding this comment.
this is going to filter all listener arguments, not just the one for parsing. It's possible to use lots of listeners at the same and just one of them would be the test parser annotation producer
There was a problem hiding this comment.
added a check for the value (annotation producer)
|
closed prior to #877 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…r if a user forgot to add the correspondent dependency in the project