Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(analytics): configurable missing analytics values #905

Merged
merged 1 commit into from
Feb 25, 2024

Conversation

Malinskiy
Copy link
Member

No description provided.

Copy link

codecov bot commented Feb 24, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 20 lines in your changes are missing coverage. Please review.

Project coverage is 59.20%. Comparing base (1fc058b) to head (3707f6c).

Files Patch % Lines
...marathon/analytics/external/MetricsProviderImpl.kt 36.36% 5 Missing and 2 partials ⚠️
...alinskiy/marathon/config/AnalyticsConfiguration.kt 33.33% 4 Missing ⚠️
...lization/yaml/GraphiteConfigurationDeserializer.kt 0.00% 4 Missing ⚠️
...athon/analytics/external/MetricsProviderFactory.kt 0.00% 3 Missing ⚠️
...lization/yaml/InfluxDbConfigurationDeserializer.kt 50.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #905      +/-   ##
=============================================
- Coverage      59.24%   59.20%   -0.05%     
- Complexity       802      804       +2     
=============================================
  Files            214      215       +1     
  Lines           4468     4483      +15     
  Branches         717      721       +4     
=============================================
+ Hits            2647     2654       +7     
- Misses          1481     1487       +6     
- Partials         340      342       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Malinskiy Malinskiy merged commit 878d2ed into develop Feb 25, 2024
9 of 11 checks passed
@Malinskiy Malinskiy deleted the feature/configurable-analytics-defaults branch February 25, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants