Global phase (cda-tum#166)

MarlQ · Aug 12, 2022 · 60a9f60 · 60a9f60
1 parent 8f1d73b
commit 60a9f60
Show file tree

Hide file tree

Showing 4 changed files with 36 additions and 3 deletions.
diff --git a/extern/json b/extern/json
diff --git a/extern/zx b/extern/zx
diff --git a/src/zx/FunctionalityConstruction.cpp b/src/zx/FunctionalityConstruction.cpp
@@ -1,6 +1,7 @@
 #include "zx/FunctionalityConstruction.hpp"
 
 #include "Definitions.hpp"
+#include "Rational.hpp"
 #include "ZXDiagram.hpp"
 
 #include <algorithm>
@@ -115,6 +116,11 @@ namespace zx {
                     break;
 
                 case qc::OpType::RZ:
+                    diag.addGlobalPhase(-PiRational(op->getParameter().front()) / 2);
+                    addZSpider(
+                            diag, target, qubits,
+                            Expression(PiRational(op->getParameter().front())));
+                    break;
                 case qc::OpType::Phase:
                     addZSpider(
                             diag, target, qubits,
@@ -126,19 +132,25 @@ namespace zx {
                     break;
 
                 case qc::OpType::RX:
+                    diag.addGlobalPhase(-PiRational(op->getParameter().front()) / 2);
                     addXSpider(
                             diag, target, qubits,
                             Expression(PiRational(op->getParameter().front())));
                     break;
 
                 case qc::OpType::Y:
+                    diag.addGlobalPhase(-PiRational(1, 2));
+
                     addZSpider(diag, target, qubits,
                                Expression(PiRational(1, 1)));
                     addXSpider(diag, target, qubits,
                                Expression(PiRational(1, 1)));
                     break;
 
                 case qc::OpType::RY:
+                    diag.addGlobalPhase(-PiRational(op->getParameter().front()) / 2 +
+                                        PiRational(1, 2) + PiRational(3, 2));
+
                     addXSpider(diag, target, qubits,
                                Expression(PiRational(1, 2)));
                     addZSpider(diag, target, qubits,

diff --git a/test/unittests/test_zx_functionality.cpp b/test/unittests/test_zx_functionality.cpp
@@ -11,6 +11,7 @@
 #include "zx/FunctionalityConstruction.hpp"
 
 #include "gtest/gtest.h"
+#include <cstddef>
 #include <iostream>
 #include <sstream>
 
@@ -120,7 +121,9 @@ TEST_F(ZXDiagramTest, complex_circuit) {
     zx::fullReduce(diag);
     EXPECT_EQ(diag.getNVertices(), 6);
     EXPECT_EQ(diag.getNEdges(), 3);
-    EXPECT_TRUE(diag.isIdentity());
+    EXPECT_TRUE(diag.connected(diag.getInput(0), diag.getOutput(0)));
+    EXPECT_TRUE(diag.connected(diag.getInput(1), diag.getOutput(1)));
+    EXPECT_TRUE(diag.connected(diag.getInput(2), diag.getOutput(2)));
 }
 
 TEST_F(ZXDiagramTest, Phase) {
@@ -201,3 +204,21 @@ TEST_F(ZXDiagramTest, InitialLayout) {
     zx::fullReduce(d);
     EXPECT_TRUE(d.isIdentity());
 }
+
+TEST_F(ZXDiagramTest, RZ) {
+    qc = qc::QuantumComputation(1);
+    qc.rz(0, zx::PI / 8);
+
+    auto qcPrime = qc::QuantumComputation(1);
+    qcPrime.phase(0, zx::PI / 8);
+
+    auto d      = zx::FunctionalityConstruction::buildFunctionality(&qc);
+    auto dPrime = zx::FunctionalityConstruction::buildFunctionality(&qcPrime);
+
+    d.concat(dPrime.invert());
+
+    zx::fullReduce(d);
+    EXPECT_FALSE(d.isIdentity());
+    EXPECT_FALSE(d.globalPhaseIsZero());
+    EXPECT_TRUE(d.connected(d.getInput(0), d.getOutput(0)));
+}
+11 −2		include/ZXDiagram.hpp
+4 −0		src/Rules.cpp
+6 −1		src/ZXDiagram.cpp
+39 −0		test/test_simplify.cpp