Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with mongodb+srv:// URIs #2205

Merged
merged 3 commits into from
Jan 3, 2025
Merged

Fix issue with mongodb+srv:// URIs #2205

merged 3 commits into from
Jan 3, 2025

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Jan 3, 2025

Closes #2197 by fixing a misleading issue when parsing mongodb+srv:// style URIs.

@ml-evs ml-evs requested a review from CasperWA as a code owner January 3, 2025 12:55
@ml-evs ml-evs added the bug Something isn't working label Jan 3, 2025
@ml-evs ml-evs force-pushed the ml-evs/fix-mongo-srv branch from 12ca06a to 66410d8 Compare January 3, 2025 14:57
Update pyproject.toml

Update pyproject.toml

Fix deprecation warning
@ml-evs ml-evs force-pushed the ml-evs/fix-mongo-srv branch from 66410d8 to 1c3818e Compare January 3, 2025 15:28
@ml-evs
Copy link
Member Author

ml-evs commented Jan 3, 2025

The CI here is blocked by materialsvirtuallab/monty#735 and materialsproject/pymatgen#4243, but as this is only a minor dependency I am happy to merge and release.

@ml-evs ml-evs merged commit b833036 into main Jan 3, 2025
7 of 10 checks passed
@ml-evs ml-evs deleted the ml-evs/fix-mongo-srv branch January 3, 2025 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aligning mongo_uri/database breaks connecting to Atlas cluster
1 participant