Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX/ADD] Fix IMPORTANT BROKEN docker errors, ADD Base Database Schema… #7

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

Matsadura
Copy link
Owner

@Matsadura Matsadura commented Sep 10, 2024

… | Metrics Routes

Pull Request Description

  • Fix 2 hours docker debugging bug that didn't allow flask to connect to MYSQL bitches
  • ADD Base Database Squeme
  • ADD Basic Metric Routes to check the integrity of the current API

Changes Made

  • MYSQL and PYTHON Environmental variables include to API service in Dockercompose
  • ADD required dependencies for MySQL Client in Flask Docker image
  • ADD A simple script that allow Flask container to run AFTER MySQL container is up, this caused Flask to not be able to connect to MySQL
  • ADD BaseMode, Mood, User, Recommendation classes
  • ADD DB_Storage
  • Delete Some redundant env from .ENV

Related Issue

ghi khlini sakt

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Using the metrics API and by manually checking the MySQL

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Additional Notes

@Matsadura
Copy link
Owner Author

Ignore Check dyal Linter hada init daba ndirlo wahd ignore rule bach mayb9ach ycheckih

Copy link
Collaborator

@Badr-Annabi Badr-Annabi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work

Copy link
Collaborator

@Badr-Annabi Badr-Annabi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work

@Badr-Annabi Badr-Annabi merged commit fe3e7b1 into dev Sep 10, 2024
0 of 2 checks passed
@Badr-Annabi Badr-Annabi deleted the BaseModel branch September 10, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants