Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for auto-incremented SERIAL columns #866

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

ml31415
Copy link

@ml31415 ml31415 commented Jan 6, 2024

Fixes #289

@ml31415 ml31415 changed the title Add support for autoincremented SERIAL columns Add support for auto-incremented SERIAL columns Jan 6, 2024
@ml31415 ml31415 changed the title Add support for auto-incremented SERIAL columns feat: Add support for auto-incremented SERIAL columns Jan 6, 2024
@ml31415 ml31415 force-pushed the main branch 2 times, most recently from 5d9562a to 778c6ad Compare January 8, 2024 10:33
@dhirschfeld
Copy link
Contributor

I just ran into this again 😬
It would be great to get this in here to work around the limitation in duckdb

@ml31415
Copy link
Author

ml31415 commented Feb 29, 2024

Hi @Mause ! Would you mind reviewing this PR? I guess it's the best workaround for the SERIAL issue currently available, until there is native support for it in duckdb.

@jobh
Copy link

jobh commented Apr 8, 2024

👍

It would be nice to include SMALLSERIAL/SMALLINT as well.

@dhirschfeld
Copy link
Contributor

It would be great if a similar trick could be used to support GENERATED ALWAYS AS IDENTITY which is the standardised form (which postgres also supports).

Maybe that's tricky enough to be best left for a follow-up PR though...

@ml31415
Copy link
Author

ml31415 commented Apr 30, 2024

It would be great if a similar trick could be used to support GENERATED ALWAYS AS IDENTITY which is the standardised form (which postgres also supports).

I guess this would better be handled by duckdb itself, as you mentioned there already: duckdb/duckdb#1768

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support SERIAL column types
3 participants