-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Svelte init #343
base: main
Are you sure you want to change the base?
Svelte init #343
Conversation
…documentation as the public folder does not contain the file
|
} | ||
} | ||
|
||
// set to false to not re-do in next step | ||
p.AdvancedOptions[string(flags.Tailwind)] = false | ||
} else { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- moved the copying of template file in else block of tailwind as currently the app file was written once and then again it was overwritten if the tailwind one needed to be copied so now it is only written once.
Going to look into this on the weekend. |
@Melkeydev yup I watched the video and read few comments about people wanting svelte and I thought it would be easy replacing just the vite template. and being newbie at Golang i thought this would be a good starting point. About the --advanced flag that is exactly what I thought when seeing the code I thought this was the beta features flag that maybe changed into the future. |
I noticed there isn't a test for react + tailwind when I was checking if svelte + tailwind test will run or not as it will the same as react |
remove duplicate
… in advanced choices
@Melkeydev fixed the |
@arafays We need to rethink the current CLI flow and implementation. However, one certainty is that a frontend flag that is independent and isolated from advanced options is the most probable solution. Implementing this requires many changes, and the code needs to be rewritten. Hopefully, this will be resolved in Q1 2025. You can leave the PR open or convert it to a draft. Once we have a clear picture and the new flag is implemented, you can update your PR. |
@Ujstor converted to draft so that the project doesnt look abandoned :D I will keep a on lookout where I can help. |
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.
Feature
Added support for init svelte as a frontend framework
Description of Changes:
npm create vite@latest --template templateOption
)CreateViteReactProject
toCreateViteProject
so this can be used for any other vite related templates that are added in the futurewhit
towith
Checklist
this is my first go project/contribution ever just been watching content related to go never made any project as I am a front-end developer so let me know if the code can be improved or restuctured for any future contributions.