Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typos suggestion #349

Closed
wants to merge 7 commits into from
Closed

Conversation

ccoVeille
Copy link

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

Problem/Feature

I started reading at the code and documentation, and I found some typos and styles issues, then I found issues with godoc.

I try to fix them all in this PR.

Description of Changes:

  • fix: acronyms
  • fix: incorrect references to slice.Contains
  • doc: add godoc links
  • godoc: respect Go convention
  • fix: typos
  • fix: style
  • doc: fix copy pasta

Checklist

Please tell me if you want me to split the PR

@Melkeydev
Copy link
Owner

I am closing this because although i appreciate the effort that you put into going over all the grammatical and I guess capitalization mistakes (Github vs GitHub), this PR is a bit unnecessary. I am going to close it and I encourage you to focus more on the actual code and programming issues, rather than spelling ones.

@Melkeydev Melkeydev closed this Dec 6, 2024
@ccoVeille ccoVeille deleted the typos-suggestion branch December 6, 2024 21:20
@ccoVeille
Copy link
Author

ccoVeille commented Dec 6, 2024

I often start to work on projects by opening small PR to see how changes and feedbacks are welcome.

Based on the fact, you deny a PR that simply try to fix minor things, and you manage to disappoint me, I will pass trying to focus on bigger changes on this repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants