docker-react-nginx-config #357
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
Just out of curiosity - is there any plans to expand this functionality? I'd typically reach for Caddy rather than nginx, for example. There are also other options such as Envoy which I currently use at work. Are we against turning this into a flag and having a few options for the user? (in the future, not suggesting a re-write of this PR) |
|
@valxntine This is a great idea, and it could be done when we are redesigning the CLI. Frontend stuff will have a separate flag, and we can expand advanced flags when Docker and frontend are paired. Caddy and Traefik with automatic SSL are something that I would like to see implemented. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.
Problem
close #339
Description of Changes:
As described in the linked issue, we should not use Node for serving static assets.
Checklist