Support Pause/Unpause MCP in Openshift #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianchiris
changed the title
Pull Request Test Coverage Report for Build 12811084017Details
💛 - Coveralls |
|
code is complete, i need to test on ocp setup. LMK if you prefer i split to multiple commits |
Implement MCPManager which pauses/unpauses MCP in openshift environments. - Add Openshift detection logic - Implement MCPManager - Integrate MCPManager in nodemaintenance controller Signed-off-by: adrianc <adrianc@nvidia.com>
adrianchiris
force-pushed
the
mcp-support
branch
2 times, most recently
from
8def208 to
a6e78a6
Compare
adrianchiris
changed the title
rollandf
reviewed
Jan 20, 2025
| reqLog.Info("Handle Scheduled NodeMaintenance") | ||
| var err error | ||
| var res ctrl.Result |
There was a problem hiding this comment.
Why do we need the res? It always the same, no?
| @@ -147,12 +152,24 @@ func main() { | |||
| ctx := ctrl.SetupSignalHandler() | |||
| mgrClient := mgr.GetClient() | |||
|
|
|||
There was a problem hiding this comment.
Why is mgr.GetAPIReader() needed? mgrClient is not enough?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement MCPManager which pauses/unpauses MCP
in openshift environments.