Skip to content

Commit

Permalink
Minor fixes for user friendliness
Browse files Browse the repository at this point in the history
  • Loading branch information
boazhaim committed Nov 5, 2024
1 parent 4ce7184 commit 65077ea
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -64,9 +64,7 @@
DIRECTORIES_TO_EXTRACT = [
"telemetry_samples"
]
DUPLICATE_LOGS_PATHS = {
"ibdiagnet2_port_counters.log":{"ufm_logs", "secondary_telemetry"}
}

def run_both_functions(parser_func, action_func, save_func):
parser_func(action_func)
save_func()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,15 @@ def full_analysis(self):
try:
func()
except:
print(":(")
function_name = func.__name__
try:
class_name = ""
if "." in func.__qualname__:
class_name = func.__qualname__.split('.')[0]
log.logging.DEBUG(f"Error when calling {function_name} {class_name}, skipping")
except:
pass

return self._images_created if len(self._images_created) > 0 else []


Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,6 @@
LOGS_GZ_POSTFIX = ".gz"
GZIP_MAGIC_NUMBER = b"\x1f\x8b" # Magic number to understand if a file is really a gzip

DUPLICATE_LOGS_PATHS = {
"ibdiagnet2_port_counters.log":{"ufm_logs", "secondary_telemetry"}
}

class DumpFilesExtractor(BaseExtractor):
def __init__(self, dump_path: Path) -> None:
dump_path = self.is_exists_get_as_path(dump_path)
Expand Down

0 comments on commit 65077ea

Please sign in to comment.