fix CI and adding constants

Signed-off-by: Elad Gershon <egershon@nvidia.com>

plugins/pdr_deterministic_plugin/tests/simulation_telemetry.py

@@ -192,7 +192,7 @@ def start_server(port:str,changes_intervals:int, run_forever:bool):
     t.daemon = True
     t.start()
     counters_names = list(counters.keys())
-    header = ['timestamp', 'source_id,tag,node_guid,Node_GUID,Port_Number'] + counters_names
+    header = ['timestamp', 'source_id,tag,Node_GUID,port_guid,Port_Number'] + counters_names
     endpoint['data'] = ""
     while True:
         # lock.acquire()

plugins/pdr_deterministic_plugin/ufm_sim_web_service/constants.py

@@ -97,6 +97,9 @@ class PDRConstants(object):
     NODE_TYPE_OTHER = "other"
     BER_TELEMETRY = "ber_telemetry"
 
+    NODE_GUID = "Node_GUID"
+    PORT_NUMBER = "Port_Number"
+
     ISSUE_PDR = "pdr"
     ISSUE_BER = "ber"
     ISSUE_PDR_BER = "pdr&ber"

plugins/pdr_deterministic_plugin/ufm_sim_web_service/isolation_mgr.py

@@ -398,10 +398,10 @@ def find_peer_row_for_port(self, port_obj, ports_counters):
             return None
         peer_guid, peer_num = port_obj.peer.split('_')
         # Fix peer guid format for future search
-        if ports_counters['port_guid'].iloc[0].startswith('0x') and not peer_guid.startswith('0x'):
+        if ports_counters[Constants.NODE_GUID].iloc[0].startswith('0x') and not peer_guid.startswith('0x'):
             peer_guid = f'0x{peer_guid}'
         #TODO check for a way to save peer row in data structure for performance
-        peer_row_list = ports_counters.loc[(ports_counters['port_guid'] == peer_guid) & (ports_counters['port_num'] == int(peer_num))]
+        peer_row_list = ports_counters.loc[(ports_counters[Constants.NODE_GUID] == peer_guid) & (ports_counters[Constants.PORT_NUMBER] == int(peer_num))]
         if peer_row_list.empty:
             self.logger.warning(f"Peer port {port_obj.peer} not found in ports data")
             return None
@@ -533,7 +533,7 @@ def read_next_set_of_high_ber_or_pdr_ports(self):
             self.logger.error("Couldn't retrieve telemetry data")
             return {}
         for _, row in ports_counters.iterrows():
-            port_name = f"{row.get('Node_GUID', '').split('x')[-1]}_{row.get('Port_Number', '')}"
+            port_name = f"{row.get(Constants.NODE_GUID, '').split('x')[-1]}_{row.get(Constants.PORT_NUMBER, '')}"
             if self.exclude_list.contains(port_name):
                 # The port is excluded from analysis
                 continue