issue:#3975912: Convert PDR to work with counters from the secondary telemetry instead of a dynamic instance #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Elad Gershon <egershon@nvidia.com>
vg12345
reviewed
Aug 14, 2024
plugins/pdr_deterministic_plugin/ufm_sim_web_service/isolation_mgr.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Elad Gershon <egershon@nvidia.com>
|
Please fix the Git Action CI |
TalLerner
approved these changes
Aug 14, 2024
Signed-off-by: Elad Gershon <egershon@nvidia.com>
Signed-off-by: Elad Gershon <egershon@nvidia.com>
Signed-off-by: Elad Gershon <egershon@nvidia.com>
drorlevy
reviewed
Aug 14, 2024
plugins/pdr_deterministic_plugin/ufm_sim_web_service/collector.py
Outdated
Show resolved
Hide resolved
plugins/pdr_deterministic_plugin/ufm_sim_web_service/collector.py
Outdated
Show resolved
Hide resolved
plugins/pdr_deterministic_plugin/ufm_sim_web_service/collector.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Elad Gershon <egershon@nvidia.com>
Signed-off-by: Elad Gershon <egershon@nvidia.com>
drorlevy
approved these changes
Aug 14, 2024
Signed-off-by: Elad Gershon <egershon@nvidia.com>
Signed-off-by: Elad Gershon <egershon@nvidia.com>
egershonNvidia
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
replacing the dynamic telemetry session with secondary telemetry.
Removing all the parts connected to the dynamic telemetry session.
we dont have telemetry collector class, this is another task.
Why ?
Task
first task in order to merge the ALM plugin and PDR plugin, we want to take secondary telemetry in the code.
How ?
It is optional, but for complex PRs please provide information about the design,
architecture, approach, etc.
Testing ?
Changed the consts in the tests with the same constants to work as well.
Special triggers
Use the following phrases as comments to trigger different runs
bot:retestrerun Jenkins CI (to rerun GitHub CI, use "Checks" tab on PR page and rerun all jobs)bot:upgraderun additional update tests