-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
issue:#4043165: Create a new telemetry_collector class #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Elad Gershon <egershon@nvidia.com>
Signed-off-by: Elad Gershon <egershon@nvidia.com>
Signed-off-by: Elad Gershon <egershon@nvidia.com>
Signed-off-by: Elad Gershon <egershon@nvidia.com>
Signed-off-by: Elad Gershon <egershon@nvidia.com>
Signed-off-by: Elad Gershon <egershon@nvidia.com>
Signed-off-by: Elad Gershon <egershon@nvidia.com>
Signed-off-by: Elad Gershon <egershon@nvidia.com>
Signed-off-by: Elad Gershon <egershon@nvidia.com>
Signed-off-by: Elad Gershon <egershon@nvidia.com>
Signed-off-by: Elad Gershon <egershon@nvidia.com>
TalLerner
approved these changes
Aug 20, 2024
Can you please rephrase the text you wrote in the why section of the PR's description? |
Signed-off-by: Elad Gershon <egershon@nvidia.com>
Signed-off-by: Elad Gershon <egershon@nvidia.com>
Signed-off-by: Elad Gershon <egershon@nvidia.com>
Signed-off-by: Elad Gershon <egershon@nvidia.com>
Signed-off-by: Elad Gershon <egershon@nvidia.com>
egershonNvidia
changed the title
issue:#4027497: Create a class that pulls the secondary telemetry every interval and send an event that new data is read
issue:#4043165: 1. Create a new telemetry_collector class
Sep 10, 2024
egershonNvidia
changed the title
issue:#4043165: 1. Create a new telemetry_collector class
issue:#4043165: Create a new telemetry_collector class
Sep 10, 2024
vg12345
approved these changes
Sep 11, 2024
TalLerner
reviewed
Sep 11, 2024
plugins/pdr_deterministic_plugin/ufm_sim_web_service/telemetry_collector.py
Outdated
Show resolved
Hide resolved
plugins/pdr_deterministic_plugin/ufm_sim_web_service/telemetry_collector.py
Show resolved
Hide resolved
Signed-off-by: Elad Gershon <egershon@nvidia.com>
TalLerner
reviewed
Sep 16, 2024
TalLerner
requested changes
Sep 16, 2024
Signed-off-by: Elad Gershon <egershon@nvidia.com>
Signed-off-by: Elad Gershon <egershon@nvidia.com>
TalLerner
reviewed
Sep 17, 2024
Signed-off-by: Elad Gershon <egershon@nvidia.com>
Signed-off-by: Elad Gershon <egershon@nvidia.com>
Signed-off-by: Elad Gershon <egershon@nvidia.com>
Signed-off-by: Elad Gershon <egershon@nvidia.com>
Signed-off-by: Elad Gershon <egershon@nvidia.com>
Signed-off-by: Elad Gershon <egershon@nvidia.com>
Signed-off-by: Elad Gershon <egershon@nvidia.com>
TalLerner
reviewed
Sep 17, 2024
Signed-off-by: Elad Gershon <egershon@nvidia.com>
TalLerner
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Separate the telemetry retrieval code into its own class in a different file.
Add a class for storing information, which saves the telemetry data and its deltas.
Why ?
Task
The second task, in order to merge the ALM and PDR plugins, is to move the telemetry to its class, decoupling the main algorithm components to prepare for the merge with ALM.
How?
took get_telemetry from ufm communication manager, put it in its class, and added a delta function to extract the delta between 2 telemetries. in another class I have put all the data store-related functions: save, remove old, and locations of folders of saved files, depending on absolute or delta. This was taken from ALM but I have put 10 items to keep, not for a particular reason. PDR plugin does not use those files, only for debugging.
Every main loop iteration, the server checks the data store to make sure that we don't overflow the data, with clean_old_files.
Testing
regular testing needs to run. Added a test to see that those files were created in the latest 5 minutes.
Added a test to make sure the data store is cleaned up and only maximum items are there.
Special triggers
Use the following phrases as comments to trigger different runs
bot:retest
rerun Jenkins CI (to rerun GitHub CI, use "Checks" tab on PR page and rerun all jobs)bot:upgrade
run additional update tests