Issue:4044453:Replace the flask framework with aiohttp in PDR plugin #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vg12345
requested review from
drorlevy,
TalLerner,
egershonNvidia and
ananalaghbar
|
bot:retest |
drorlevy
approved these changes
Aug 29, 2024
plugins/pdr_deterministic_plugin/ufm_sim_web_service/api/base_aiohttp_api.py
Outdated
Show resolved
Hide resolved
Not necessary but more readable. I decided to define all common, API-specific independent functionality to base class. In addition, we can later move the base class to utils and reuse. |
ananalaghbar
approved these changes
Aug 29, 2024
|
bot:retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Replace the flask framework with aiohttp in PDR plugin
Why ?
#4044453
Testing ?
Automatic tests
Special triggers
Use the following phrases as comments to trigger different runs
bot:retestrerun Jenkins CI (to rerun GitHub CI, use "Checks" tab on PR page and rerun all jobs)bot:upgraderun additional update tests