issue:4091669 PDR plugin is not isolate based on LinkDownedCounter measurements #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vg12345
requested review from
egershonNvidia,
TalLerner and
ananalaghbar
and removed request for
egershonNvidia
ananalaghbar
approved these changes
Sep 29, 2024
egershonNvidia
approved these changes
Sep 30, 2024
TalLerner
reviewed
Sep 30, 2024
plugins/pdr_deterministic_plugin/ufm_sim_web_service/telemetry_collector.py
Show resolved
Hide resolved
TalLerner
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fix for telemetry delta calculation in data collector.
Non-numeric data raises type error exception.
Why ?
#4091669
PDR plugin does not isolate based on LinkDownedCounter measurements
Exception raised during telemetry delta calculation of data collector.
How ?
Handle invalid data in telemetry delta calculation of data collector.
Original delta calculation subtracted two data columns, but validated data types for one (first) item only.
Applied fix validates that all items in both data columns have correct type.
Testing ?
Automatic and manual tests
Special triggers
Use the following phrases as comments to trigger different runs
bot:retestrerun Jenkins CI (to rerun GitHub CI, use "Checks" tab on PR page and rerun all jobs)bot:upgraderun additional update tests