Task #4111576: Add TFS upgrade script #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Miryam-Schwartz
requested review from
drorlevy,
vg12345,
ananalaghbar,
TalLerner and
egershonNvidia
drorlevy
approved these changes
Nov 17, 2024
Miryam-Schwartz
force-pushed
the
upgrade_script
branch
from
bcdf34e to
db5be8f
Compare
plugins/fluentd_telemetry_plugin/src/merge_configuration_files.py
Outdated
Show resolved
Hide resolved
plugins/fluentd_telemetry_plugin/src/merge_configuration_files.py
Outdated
Show resolved
Hide resolved
plugins/fluentd_telemetry_plugin/src/merge_configuration_files.py
Outdated
Show resolved
Hide resolved
plugins/fluentd_telemetry_plugin/src/merge_configuration_files.py
Outdated
Show resolved
Hide resolved
|
bot:retest |
|
bot:retest |
1 similar comment
|
bot:retest |
This reverts commit dceb191.
ananalaghbar
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add an upgrade script to the TFS plugin.
Why ?
https://redmine.mellanox.com/issues/4111576
How ?
Add merge_configuration_files.py to merge user and new configurations (The file was added to ufm_sdk_tools).
Add upgrade.sh script that calls the Python script.
Add upgrade.sh to the TFS plugin container.
Testing ?
merge_configuration_files.py was tested manually.
Special triggers
Use the following phrases as comments to trigger different runs
bot:retestrerun Jenkins CI (to rerun GitHub CI, use "Checks" tab on PR page and rerun all jobs)bot:upgraderun additional update tests