-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/git lab support #82
base: master
Are you sure you want to change the base?
Feature/git lab support #82
Conversation
Add all files and classes to support GitLab via APIv4, set base url, use tokens
Hi, Another thing is, I'd prefer to not have author specific headers in each file. This project already has multiple contributors and i'd like to keep the actualy source files clean from whoever added to them. Adding a contributors file to the repo with mentions of what they contributed to might be a good idea and something I should add later on if it is desired(which it seems ;) ). PS: If your feature needs the multisource feature, I'll need to kick myself to get this one polished so we can get all of it back to master. |
Sorry for the late reply! I know what it's like to be busy because of work. Yes, my starting point was indeed the feature/multisource branch. This seemed to be the most suitable base, so I started from there. Not using author-specific headers is not a problem, I just didn't know that. I will change the headers and commit them again. Can I help in any way with the multisource function? I would find it practical to be able to specify multiple sources in general. What features or tests are still missing here to make this available in the master? Best regards, Matthias |
No problem :) For this I plan to extend the And commandline. IIRC the commandline does not yet operate on an aggregated source which encapsulates all subsources like the IDE-Extension. And possible additions to the commandline to allow specifying specific sources when installing a package. Though, for times sake, I plan to just let it operate on an aggregated source for the first release. |
Hi, I have added a GitLab support that uses the GitLab API. A base URL can be specified so that different GitLab instances can be specified as source. The authentication with tokens already implemented for GitHub has also been implemented for GitLab.
The package manager is a great idea and therefore I would like to extend it.
Please feel free to contact me with any questions. Best regards, Matthias Heunecke