Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gh#67 migration vue3 #135

Merged
merged 5 commits into from
Dec 5, 2023
Merged

Gh#67 migration vue3 #135

merged 5 commits into from
Dec 5, 2023

Conversation

MarcelGeo
Copy link
Contributor

@MarcelGeo MarcelGeo commented Dec 4, 2023 •
edited
Loading

Created:

  • lib-vue2 package for compatibility of admin with vue2 (TODO: extract functions to utils package)

MIgration to vue3

  • lib / app package with vuetify3
  • primevue installed and used for sidebar and appheader
  • migration of files from previous branch (editorconfig ...)

Upgrade of packages:

  • sass
  • vue
  • pinia
  • vue-router

Packages upgrade:

Web application @mergin/app is using shared library @mergin/lib. Web application for administratio admin-app is using shared libraries with vue 2.7 @mergin/admin-lib and @mergin/lib-vue2. No change in commands.

@MarcelGeo
Added:
43a34e6 
- lib-vue2 with all components for compatibility of admin-app, admin-lib
- vue3 for lib and app
Admin can be builded from this version with vue2.7
@MarcelGeo
Added primevue
7491943 
Migrated Sidebar and AppHeader
Removing vuetify override css
@MarcelGeo
Cleanup docker compose for dev db
d4e78ae
@MarcelGeo MarcelGeo requested a review from varmar05 December 4, 2023 08:06
@coveralls
Copy link

coveralls commented Dec 4, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 7098151665

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.798%
Totals Coverage Status
Change from base Build 6969002712: 0.0%
Covered Lines: 5475
Relevant Lines: 5837
💛 - Coveralls

@MarcelGeo MarcelGeo self-assigned this Dec 4, 2023
@MarcelGeo
Upgrade readme
dcc67b2
@MarcelGeo
- Upgrade sass to newest version (with warining :( )
ca519b4 
- Add tabler-icons 1.x for lib-vue2 to fix using vue2 instead vue3
@MarcelGeo MarcelGeo merged commit 8d36f3b into develop-redesign Dec 5, 2023
3 of 4 checks passed
@MarcelGeo MarcelGeo deleted the gh#67-migration-vue3 branch December 5, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@varmar05 varmar05 varmar05 approved these changes

Assignees

@MarcelGeo MarcelGeo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MarcelGeo @coveralls @varmar05