-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Roles refactor: New public API with reworked project roles #337
Conversation
Pull Request Test Coverage Report for Build 12238117740Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just minor suggestions and one question:
- do we want to use ProjectPermissions.Upload and other methods from project permissions class? I think we could rewrite it or remove.
I did not touch this one, as it is widely used. If we want further refactoring then I'd probably vote for removing it completely. So far it is hanging there if we one day decide to introduce permissions besides roles. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious why we split that project access PUT.
Added new public
/v2
endpoints for project members CRUD and new endpoint for registration of users.Also small refactoring was done (e.g. moving workspace role definition from EE).