Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add editor limit hit blocking #343

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Add editor limit hit blocking #343

merged 1 commit into from
Dec 16, 2024

Conversation

varmar05
Copy link
Contributor

This is CE part for integration of new editor limit hit blocking mechanism. PR adds:

  • a new error type
  • a revert mechanism for updates that were rejected

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12318536813

Details

  • 5 of 11 (45.45%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.08%) to 93.406%
Changes Missing Coverage Covered Lines Changed/Added Lines %
server/mergin/sync/public_api_controller.py 5 11 45.45%
Totals Coverage Status
Change from base Build 12276007973: -0.08%
Covered Lines: 6587
Relevant Lines: 7052
💛 - Coveralls

@MarcelGeo MarcelGeo merged commit e7dfd74 into develop Dec 16, 2024
4 checks passed
@MarcelGeo MarcelGeo deleted the editor_limit_blocking branch December 16, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcelGeo MarcelGeo MarcelGeo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@varmar05 @coveralls @MarcelGeo