Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to define custom projection. #166

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

thomascrocker
Copy link
Collaborator

@thomascrocker thomascrocker commented Nov 27, 2020

This PR adds the ability to explicitly set the projection used to produce the plot. The prior behaviour simply used the projection of the supplied data. It addresses #164
If the user specifies a projection that is different to that of the supplied data, the data is transformed onto the new projection.
Also if the data does not have a co-ordinate system (e.g. most of the CMIP5 data under /project/champ) PlateCarree is assumed.

Lastly I removed the try clauses around getting the x and y coords, since if a coord not found error is ignored here it will almost certainly cause problems further on but be harder to debug.

@nhsavage nhsavage self-requested a review December 12, 2020 19:06
@nhsavage nhsavage assigned nhsavage and unassigned nhsavage Dec 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants