Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snaps Pages #113

Merged
merged 6 commits into from
Oct 31, 2023
Merged

Snaps Pages #113

merged 6 commits into from
Oct 31, 2023

Conversation

FrederikBolding
Copy link
Member

@FrederikBolding FrederikBolding commented Oct 26, 2023

Adds draft for the snaps home page feature.

Fixes https://github.com/MetaMask/MetaMask-planning/issues/1386

Mrtenz
Mrtenz previously requested changes Oct 26, 2023
SIPS/sip-15.md Outdated Show resolved Hide resolved
SIPS/sip-15.md Outdated Show resolved Hide resolved
FrederikBolding and others added 2 commits October 26, 2023 21:04
Co-authored-by: Maarten Zuidhoorn <maarten@zuidhoorn.com>
SIPS/sip-15.md Outdated Show resolved Hide resolved
SIPS/sip-15.md Outdated Show resolved Hide resolved
SIPS/sip-15.md Outdated Show resolved Hide resolved
Copy link
Contributor

@Montoya Montoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Multiple comments made in-line

SIPS/sip-15.md Outdated Show resolved Hide resolved
@FrederikBolding FrederikBolding marked this pull request as ready for review October 31, 2023 19:21
@FrederikBolding FrederikBolding requested review from ziad-saab and a team as code owners October 31, 2023 19:21
Copy link
Contributor

@Montoya Montoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FrederikBolding FrederikBolding merged commit e4a1f79 into main Oct 31, 2023
2 checks passed
@FrederikBolding FrederikBolding deleted the fb/snaps-pages branch October 31, 2023 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants