SIP-26: Update Snaps-specific parts of the specification #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adonesky1
reviewed
Nov 13, 2024
adonesky1
reviewed
Nov 13, 2024
Co-authored-by: Alex Donesky <alex.donesky@consensys.net>
danroc
approved these changes
Nov 14, 2024
FrederikBolding
added a commit
that referenced
this pull request
Nov 14, 2024
* Add draft of SIP-26 * Remove optional header fields * Add SIP number and remove unused optional fields * Rename diagram image * Rename components diagram in document * Update diagram and add components descriptions * Rename "Address Resolution Snaps" to "Account Address Resolution Snaps" * Update components diagram * Update `resolveAccountAddress` signature * Add link to CAIP-2 and remove commented text * Add Protocol Snaps * Update components diagram * Update `resolveAccountAddress` docs * Clarify: should -> MUST * Update `resolveAccountAddress` method * Remove mention to SIP-25 * Add note about Snap events * Minor text improvements * Add mention to CAIP-2 chain IDs Co-authored-by: Gustavo Antunes <17601467+gantunesr@users.noreply.github.com> * Update keyring-api repo URL Co-authored-by: Charly Chevalier <charlyy.chevalier@gmail.com> * Add note about Accounts Router and Protocol Snaps priority * chore: update SIP-26 following latest discussions * SIP-26: Update Snaps-specific parts of the specification (#153) * SIP-26: Update Snaps-specific parts of the specification * Minor updates * Reword slightly * Update SIPS/sip-26.md Co-authored-by: Alex Donesky <alex.donesky@consensys.net> --------- Co-authored-by: Alex Donesky <alex.donesky@consensys.net> * chore: update title Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com> * Apply suggestions from code review Co-authored-by: Alex Donesky <alex.donesky@consensys.net> * Update SIPS/sip-26.md --------- Co-authored-by: Gustavo Antunes <17601467+gantunesr@users.noreply.github.com> Co-authored-by: Charly Chevalier <charlyy.chevalier@gmail.com> Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com> Co-authored-by: Alex Donesky <alex.donesky@consensys.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes a couple of updates to SIP-26 to add some details for permission specifications, the required Snap export and account resolution.