-
Notifications
You must be signed in to change notification settings - Fork 570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Skeleton component #3024
Merged
Merged
Add Skeleton component #3024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
david0xd
force-pushed
the
dd/add-skeleton-component
branch
from
January 16, 2025 20:40
09ffc44
to
f584d23
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3024 +/- ##
=======================================
Coverage 94.76% 94.76%
=======================================
Files 499 500 +1
Lines 10906 10911 +5
Branches 1672 1672
=======================================
+ Hits 10335 10340 +5
Misses 571 571 ☔ View full report in Codecov by Sentry. |
Mrtenz
requested changes
Jan 17, 2025
Mrtenz
reviewed
Jan 17, 2025
Mrtenz
requested changes
Jan 20, 2025
Mrtenz
approved these changes
Jan 20, 2025
david0xd
force-pushed
the
dd/add-skeleton-component
branch
from
January 20, 2025 14:08
b824b3c
to
9b0d9a7
Compare
david0xd
force-pushed
the
dd/add-skeleton-component
branch
from
January 20, 2025 14:32
9b0d9a7
to
fd05758
Compare
FrederikBolding
pushed a commit
to MetaMask/metamask-extension
that referenced
this pull request
Jan 27, 2025
## **Description** Add Skeleton to Snaps UI components. [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/29764?quickstart=1) ## **Related issues** Fixes: MetaMask/snaps#2940 ## **Related Pull Requests** Snaps PR: MetaMask/snaps#3024 ## **Manual testing steps** 1. Make and install test Snap with source code that uses Skeleton component. 2. Check if it matches expectations. Snap UI JSX code used for testing: ```typescript <Container> <Box> <Text>Skeleton inside text component:</Text> <Text> <Skeleton /> </Text> <Text>Classic Skeleton inside a box:</Text> <Skeleton /> <Text>Top level Skeleton: </Text> <Skeleton height={32} width="100%" /> <Skeleton height={16} width="50%" borderRadius="none" /> <Skeleton height={16} width="25%" borderRadius="medium" /> <Skeleton height={32} width={32} borderRadius="full" /> <Text>Skeleton inside Section: </Text> <Section> <Skeleton height={32} width="100%" /> <Skeleton height={16} width="50%" borderRadius="none" /> <Skeleton height={16} width="25%" borderRadius="medium" /> <Skeleton height={32} width={32} borderRadius="full" /> </Section> <Text>Skeleton inside Row: </Text> <Row label="Row"> <Skeleton height={22} width="30%" /> </Row> <Row label="Row"> <Text> <Skeleton height={22} width={40} /> </Text> </Row> </Box> </Container> ``` ## **Screenshots/Recordings** ### **Before** Skeleton was not available before. Nothing to show here. ### **After** ![Screenshot 2025-01-17 at 13 09 22](https://github.com/user-attachments/assets/fb1be740-f06d-4da0-80ec-7fb3c5cbf1d3) ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Skeleton component.
Related PR in extension: MetaMask/metamask-extension#29764
Code example
JSX code used for testing:
Screenshots