-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IBS Table Fix and Code Source Comments #1210
IBS Table Fix and Code Source Comments #1210
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok to me, waiting for the tests to run
I've made just a few corrections / additions. Interesting to note, that I forgot to mention initially: it seems (empirically, to me) that the IBS table is only created internally when the command is called with a value for an output file ( |
Feel free to create the table anyway if it is helpful for your use case. |
Hi @rdemaria, here are a few more changes then:
This way when calling
A quick local build shows that all of this works, but let's run the tests to be sure. I could also make a small addition to the IBS section in the user guide repo to specify one might access the coulomb log and the common constant the same as the growth rates. Should I? |
Yes please add two lines to the manual if it.is easy to do so... |
…w exported variables.
Done! I have also brought in a little correction about the Let me know if this looks alright to you @rdemaria |
@rdemaria I'm not sure what went wrong with this single Windows build, but it seems it received an interrupt signal due to the runtime timeout of 30min defined in the workflow file (currently line 176). Would it be possible to try reruning just this one? I'm fairly confident it would pass just fine. |
@rdemaria I had to fix a mistake I had made in the documentation, sorry. The tests passed fine when you reran, could you approve once more? |
Hello,
Since I have looked at the IBS module source code (ibsdb.f90) quite a lot for work recently, I figured it would be beneficial to submit a PR with an "improved" (as much as I could) documentation of this module.
Important point: No code change is made in this PR.
All this PR brings is a lot of comments trying to explain:
I'm not 100% sure I am correct on everything in here, but almost all my additions should be correct and, hopefully, helpful.