Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

State implementation files - Mavsdk to drone kit replacement #23

Open
DJDMVP opened this issue Sep 17, 2024 · 1 comment
Open

State implementation files - Mavsdk to drone kit replacement #23

DJDMVP opened this issue Sep 17, 2024 · 1 comment
Assignees
@RexBerry
Labels
enhancement New feature or request flight Flight subteam / controls the flight or overarching control of the drone good first issue Good for newcomers

Comments

@DJDMVP
Copy link

DJDMVP commented Sep 17, 2024 •
edited
Loading

State implementation files Mavsdk to drone kit replacement

Problem

Replace the mavsdk commands in state_machine/states/impl with dronekit commands. The files that should need replacement are takeoff, waypoint, and land.

create the new branch for the feature off of the branch "feature/dronekit" This is to keep code for dronekit seperated until we are ready to fully replace mavsdk.

Solution

Mavsdk commands are no longer needed in the state_machine/states/impl folder and is instead replaced with dronekit commands.

Additional Information

Dronekit Docs
@DJDMVP DJDMVP added enhancement New feature or request good first issue Good for newcomers flight Flight subteam / controls the flight or overarching control of the drone labels Sep 17, 2024
@DJDMVP DJDMVP changed the title State implementation Mavsdk to drone kit replacement State implementation files - Mavsdk to drone kit replacement Sep 17, 2024
@RexBerry RexBerry self-assigned this Sep 20, 2024
RexBerry added a commit that referenced this issue Sep 25, 2024
@RexBerry
Convert most state code from MAVSDK to DroneKit (currently untested) #23
ed9a1fc
RexBerry added a commit that referenced this issue Sep 27, 2024
@RexBerry
Convert mode code to DroneKit #23
3de1874
RexBerry added a commit that referenced this issue Oct 2, 2024
@RexBerry
Fix dronekit code mostly related to connecting to the drone #23
711f739
RexBerry added a commit that referenced this issue Oct 2, 2024
@RexBerry
Fix potential bug in start state #23
4ca9dfa
RexBerry added a commit that referenced this issue Oct 4, 2024
@RexBerry
Fix typing bug in waypoint state impl #23
c7bfda4
RexBerry added a commit that referenced this issue Oct 9, 2024
@RexBerry
Update SUAS test to use DroneKit #23
65478b3
RexBerry added a commit that referenced this issue Oct 9, 2024
@RexBerry
Update airdrop unit test to use DroneKit #23
0840ce5
RexBerry added a commit that referenced this issue Oct 9, 2024
@RexBerry
Update Hoffman waypoint test to use DroneKit #23
90d7e20
RexBerry added a commit that referenced this issue Oct 9, 2024
@RexBerry
Update kill switch test to use DroneKit #23
91b52dc
@RexBerry
Copy link

RexBerry commented Oct 9, 2024

All imports of mavsdk have been removed.

RexBerry added a commit that referenced this issue Nov 15, 2024
@RexBerry
Use golf_data.json in unit tests #23
dfdbb4d
RexBerry added a commit that referenced this issue Nov 15, 2024
@RexBerry
Use state tracker consistently in state impls #23
12d23c2
RexBerry added a commit that referenced this issue Nov 15, 2024
@RexBerry
Fix unit test module docstrings #23
9db044e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RexBerry RexBerry

Labels
enhancement New feature or request flight Flight subteam / controls the flight or overarching control of the drone good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@RexBerry @DJDMVP