-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unused-imports tool #6
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for comparison we run swiftlint's logic sharded and it takes ~15 hours of machine time. The current implementation here takes ~20 seconds |
codeman9
previously approved these changes
Mar 28, 2023
sebastianv1
reviewed
Mar 28, 2023
sebastianv1
reviewed
Mar 28, 2023
sebastianv1
reviewed
Mar 28, 2023
sebastianv1
reviewed
Mar 28, 2023
sebastianv1
reviewed
Mar 28, 2023
sebastianv1
reviewed
Mar 29, 2023
keith
force-pushed
the
ks/add-unused-imports-tool
branch
from
March 29, 2023 22:42
6e173e1
to
b40a012
Compare
pennig
reviewed
Apr 4, 2023
Ok i think this is good enough to merge, the checks that aren't done can be done as follow ups and will be more understandable at this point. if you try this and find any issues let me know! |
sberrevoets
reviewed
Apr 5, 2023
sberrevoets
reviewed
Apr 5, 2023
sberrevoets
reviewed
Apr 5, 2023
sberrevoets
previously approved these changes
Apr 5, 2023
This tool uses the index data to suggest imports that can be removed from your files. Currently compared to SwiftLint's implementation it's much faster, but doesn't yet add missing imports, or remove unused system imports. It's currently lightly affected by upstream issues listed here #5
perf win
Co-authored-by: Scott Berrevoets <sberrevoets@lyft.com>
keith
force-pushed
the
ks/add-unused-imports-tool
branch
from
April 5, 2023 18:44
cde3a78
to
c516990
Compare
sberrevoets
approved these changes
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tool uses the index data to suggest imports that can be removed
from your files. Currently compared to SwiftLint's implementation it's
much faster, but doesn't yet add missing imports, or remove unused
system imports.
It's currently lightly affected by upstream issues listed here
#5
Todos:
Parallelize (probably v2)