[DRAFT] Build on macOS #77
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quite dirty and would brake linux build, but shows what is missing for macOS build.
dpxcc
force-pushed
the
main
branch
2 times, most recently
from
2af4b2b to
6a655ea
Compare
bayandin
reviewed
Jan 10, 2025
|
|
||
| clean-duckdb: | ||
| $(MAKE) -C third_party/duckdb clean | ||
|
|
||
| third_party/duckdb/build/$(BUILD_TYPE)/src/libduckdb.so: | .BUILD | ||
| third_party/duckdb/build/$(BUILD_TYPE)/src/libduckdb.dylib: | .BUILD |
There was a problem hiding this comment.
Postgres prior to 16 still expects the so suffix.
It was changes in postgres/postgres@b55f62a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quite dirty and would break linux build, but shows what is missing for macOS build.
To build run
CXXFLAGS="-std=c++17 -Wno-overloaded-virtual" make release -j.no-overloaded-virtualis better to fix in the code itself.