-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mostro in Rust Workspace fashion #410
base: main
Are you sure you want to change the base?
Conversation
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Hi @grunch ,
here a MVP of workspace idea, take a look and think about, dropping here a list of advantages (imo):
Mostro
,Mostro-cli
andMostro-core
this means no more patch with local repo of mostro core. Now mostro-core is just a dep of mostro so we are always using local version with latest things ready for use. Anyone can get all needed tool to test mostro with just one project.- clean
- build
- builddb
- buildall
you can easily understand what they do reading the code in
src\xtask\main.rs
: for example now withbuilddb
you will recreate db without shell but just pure rust and we can do all the same we do with shell.Buildall
will do everything: clean, build db, and build all packages.just -l
to get a list...The only thing to add is just with a simple cargo command.
Ok just a starting point...
@bilthon @Catrya let me know your opinion too...