Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

my change #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

my change #2

wants to merge 1 commit into from

Conversation

MrKevinWeiss
Copy link
Owner

Contribution description

Testing procedure

Issues/PRs references

@riot-hil-bot
Copy link

HiL Test Results

PASS FAIL SKIP
147 7 1
  ❌ z1 (1 fail test)
PASS FAIL SKIP
4 1 0
TEST RESULT
tests/shell ❌ test fail
tests/ztimer_msg ✅ pass
tests/pthread ✅ pass
tests/msg_avail ✅ pass
tests/xtimer_drift ✅ pass
  ❌ hifive1b (1 fail test)
PASS FAIL SKIP
4 1 0
TEST RESULT
tests/shell ❌ test fail
tests/ztimer_msg ✅ pass
tests/pthread ✅ pass
tests/msg_avail ✅ pass
tests/xtimer_drift ✅ pass
  ❌ frdm-k64f (1 fail test) (3 fail flash)
PASS FAIL SKIP
1 4 0
TEST RESULT
tests/ztimer_msg ❌ test fail
tests/pthread 😬 flash fail
tests/msg_avail 😬 flash fail
tests/xtimer_drift 😬 flash fail
tests/shell ✅ pass
  ❌ stk3200 (1 fail test)
PASS FAIL SKIP
3 1 1
TEST RESULT
tests/ztimer_msg ❌ test fail
tests/pthread ✅ pass
tests/msg_avail ✅ pass
tests/xtimer_drift 🙈 skip
tests/shell ✅ pass
  ✅ frdm-k22f
PASS FAIL SKIP
5 0 0
TEST RESULT
tests/ztimer_msg ✅ pass
tests/pthread ✅ pass
tests/msg_avail ✅ pass
tests/xtimer_drift ✅ pass
tests/shell ✅ pass
  ✅ nucleo-f091rc
PASS FAIL SKIP
5 0 0
TEST RESULT
tests/ztimer_msg ✅ pass
tests/pthread ✅ pass
tests/msg_avail ✅ pass
tests/xtimer_drift ✅ pass
tests/shell ✅ pass
  ✅ nucleo-f303re
PASS FAIL SKIP
5 0 0
TEST RESULT
tests/ztimer_msg ✅ pass
tests/pthread ✅ pass
tests/msg_avail ✅ pass
tests/xtimer_drift ✅ pass
tests/shell ✅ pass
  ✅ nucleo-g474re
PASS FAIL SKIP
5 0 0
TEST RESULT
tests/ztimer_msg ✅ pass
tests/pthread ✅ pass
tests/msg_avail ✅ pass
tests/xtimer_drift ✅ pass
tests/shell ✅ pass
  ✅ nucleo-f767zi
PASS FAIL SKIP
5 0 0
TEST RESULT
tests/ztimer_msg ✅ pass
tests/pthread ✅ pass
tests/msg_avail ✅ pass
tests/xtimer_drift ✅ pass
tests/shell ✅ pass
  ✅ nucleo-l152re
PASS FAIL SKIP
5 0 0
TEST RESULT
tests/ztimer_msg ✅ pass
tests/pthread ✅ pass
tests/msg_avail ✅ pass
tests/xtimer_drift ✅ pass
tests/shell ✅ pass
  ✅ nucleo-f207zg
PASS FAIL SKIP
5 0 0
TEST RESULT
tests/ztimer_msg ✅ pass
tests/pthread ✅ pass
tests/msg_avail ✅ pass
tests/xtimer_drift ✅ pass
tests/shell ✅ pass
  ✅ arduino-mega2560
PASS FAIL SKIP
5 0 0
TEST RESULT
tests/ztimer_msg ✅ pass
tests/pthread ✅ pass
tests/msg_avail ✅ pass
tests/xtimer_drift ✅ pass
tests/shell ✅ pass
  ✅ nucleo-l432kc
PASS FAIL SKIP
5 0 0
TEST RESULT
tests/ztimer_msg ✅ pass
tests/pthread ✅ pass
tests/msg_avail ✅ pass
tests/xtimer_drift ✅ pass
tests/shell ✅ pass
  ✅ samr34-xpro
PASS FAIL SKIP
5 0 0
TEST RESULT
tests/ztimer_msg ✅ pass
tests/pthread ✅ pass
tests/msg_avail ✅ pass
tests/xtimer_drift ✅ pass
tests/shell ✅ pass
  ✅ saml10-xpro
PASS FAIL SKIP
5 0 0
TEST RESULT
tests/ztimer_msg ✅ pass
tests/pthread ✅ pass
tests/msg_avail ✅ pass
tests/xtimer_drift ✅ pass
tests/shell ✅ pass
  ✅ saml11-xpro
PASS FAIL SKIP
5 0 0
TEST RESULT
tests/ztimer_msg ✅ pass
tests/pthread ✅ pass
tests/msg_avail ✅ pass
tests/xtimer_drift ✅ pass
tests/shell ✅ pass
  ✅ samr30-xpro
PASS FAIL SKIP
5 0 0
TEST RESULT
tests/ztimer_msg ✅ pass
tests/pthread ✅ pass
tests/msg_avail ✅ pass
tests/xtimer_drift ✅ pass
tests/shell ✅ pass
  ✅ samr21-xpro
PASS FAIL SKIP
5 0 0
TEST RESULT
tests/ztimer_msg ✅ pass
tests/pthread ✅ pass
tests/msg_avail ✅ pass
tests/xtimer_drift ✅ pass
tests/shell ✅ pass
  ✅ nrf52dk
PASS FAIL SKIP
5 0 0
TEST RESULT
tests/ztimer_msg ✅ pass
tests/pthread ✅ pass
tests/msg_avail ✅ pass
tests/xtimer_drift ✅ pass
tests/shell ✅ pass
  ✅ remote-revb
PASS FAIL SKIP
5 0 0
TEST RESULT
tests/ztimer_msg ✅ pass
tests/pthread ✅ pass
tests/msg_avail ✅ pass
tests/xtimer_drift ✅ pass
tests/shell ✅ pass
  ✅ nucleo-l073rz
PASS FAIL SKIP
5 0 0
TEST RESULT
tests/ztimer_msg ✅ pass
tests/pthread ✅ pass
tests/msg_avail ✅ pass
tests/xtimer_drift ✅ pass
tests/shell ✅ pass
  ✅ slstk3401a
PASS FAIL SKIP
5 0 0
TEST RESULT
tests/ztimer_msg ✅ pass
tests/pthread ✅ pass
tests/msg_avail ✅ pass
tests/xtimer_drift ✅ pass
tests/shell ✅ pass
  ✅ nucleo-f411re
PASS FAIL SKIP
5 0 0
TEST RESULT
tests/ztimer_msg ✅ pass
tests/pthread ✅ pass
tests/msg_avail ✅ pass
tests/xtimer_drift ✅ pass
tests/shell ✅ pass
  ✅ nucleo-f103rb
PASS FAIL SKIP
5 0 0
TEST RESULT
tests/ztimer_msg ✅ pass
tests/pthread ✅ pass
tests/msg_avail ✅ pass
tests/xtimer_drift ✅ pass
tests/shell ✅ pass
  ✅ frdm-kw41z
PASS FAIL SKIP
5 0 0
TEST RESULT
tests/ztimer_msg ✅ pass
tests/pthread ✅ pass
tests/msg_avail ✅ pass
tests/xtimer_drift ✅ pass
tests/shell ✅ pass
  ✅ esp8266-esp-12x
PASS FAIL SKIP
5 0 0
TEST RESULT
tests/ztimer_msg ✅ pass
tests/pthread ✅ pass
tests/msg_avail ✅ pass
tests/xtimer_drift ✅ pass
tests/shell ✅ pass
  ✅ esp32-wroom-32
PASS FAIL SKIP
5 0 0
TEST RESULT
tests/ztimer_msg ✅ pass
tests/pthread ✅ pass
tests/msg_avail ✅ pass
tests/xtimer_drift ✅ pass
tests/shell ✅ pass
  ✅ arduino-due
PASS FAIL SKIP
5 0 0
TEST RESULT
tests/ztimer_msg ✅ pass
tests/pthread ✅ pass
tests/msg_avail ✅ pass
tests/xtimer_drift ✅ pass
tests/shell ✅ pass
  ✅ slstk3400a
PASS FAIL SKIP
5 0 0
TEST RESULT
tests/ztimer_msg ✅ pass
tests/pthread ✅ pass
tests/msg_avail ✅ pass
tests/xtimer_drift ✅ pass
tests/shell ✅ pass
  ✅ saml21-xpro
PASS FAIL SKIP
5 0 0
TEST RESULT
tests/ztimer_msg ✅ pass
tests/pthread ✅ pass
tests/msg_avail ✅ pass
tests/xtimer_drift ✅ pass
tests/shell ✅ pass
  ✅ same54-xpro
PASS FAIL SKIP
5 0 0
TEST RESULT
tests/ztimer_msg ✅ pass
tests/pthread ✅ pass
tests/msg_avail ✅ pass
tests/xtimer_drift ✅ pass
tests/shell ✅ pass

MrKevinWeiss pushed a commit that referenced this pull request Feb 1, 2022
@benpicco
tests/pkg_mbedtls-blacklist: blacklist samr21-xpro
3c6241b 
The ENTROPY test always fails on this board

main(): This is RIOT! (Version: buildtest)
mbedtls test

  SHA-224 test #1: passed
  SHA-224 test #2: passed
  SHA-224 test #3: passed
  SHA-256 test #1: passed
  SHA-256 test #2: passed
  SHA-256 test #3: passed

  ENTROPY test: failed
MrKevinWeiss pushed a commit that referenced this pull request Feb 20, 2023
@bors @HendrikVE @Teufelchen1
Merge RIOT-OS#19270 RIOT-OS#19271
5667814 
19270: drivers/at24cxxx: implement _mtd_at24cxxx_read_page r=benpicco a=HendrikVE

### Contribution description

The function `read_page` was missing which lead to (from a user perspective) undefined behavior on the MTD layer.

### Testing procedure

Any application using MTD in conjunction with a board with an at24cxxx.


19271: core/xfa: disable asan on llvm r=benpicco a=Teufelchen1

### Contribution description
Hi! 🦎

When using llvm and address sanitation, the XFA trip the sanitizer.
This PR attempts to fix this by adding the `no_sanitize` attribute to the XFA macros. Sadly, this attribute is not known by gnu, a guard is hence needed. I'm open for alternatives as I dislike this solution but it is the best I could come up with.

### Testing procedure

Before this patch:

Go to `examples/gnrc_minimal` and run `TOOLCHAIN=llvm make all-asan` and then `make term`.
You should see an error similar to this:
```
==3374719==ERROR: AddressSanitizer: global-buffer-overflow on address 0x080774e0 at pc 0x0804af5e bp 0x0808eb88 sp 0x0808eb78
READ of size 4 at 0x080774e0 thread T0
    #0 0x804af5d in _auto_init_module /RIOT/sys/auto_init/auto_init.c:40
    #1 0x804af5d in auto_init /RIOT/sys/auto_init/auto_init.c:339
    #2 0x804b375 in main_trampoline /RIOT/core/lib/init.c:56
    #3 0xf76bc7b8 in makecontext (/lib32/libc.so.6+0x4a7b8)
...
``` 
After applying this PR, the example can be build and run with llvm or gcc, with or without asan.



Co-authored-by: Hendrik van Essen <hendrik.vanessen@ml-pa.com>
Co-authored-by: Teufelchen1 <bennet.blischke@haw-hamburg.de>
MrKevinWeiss pushed a commit that referenced this pull request Mar 2, 2023
@bors
Merge RIOT-OS#18392
41b54d8 
18392: drivers/servo: reimplement with high level interface r=benpicco a=maribu

### Contribution description

The previous servo driver didn't provide any benefit over using PWM directly, as users controlled the servo in terms of PWM duty cycles. This changes the interface to provide a high level interface that abstracts the gory PWM details.

In addition, a SAUL layer and auto-initialization is provided.

### Testing procedure

The test application provides access to the servo driver via the `saul` shell command.

```
> saul
2022-08-02 22:12:31,826 # saul
2022-08-02 22:12:31,827 # ID	Class		Name
2022-08-02 22:12:31,830 # #0	ACT_SWITCH	LD1(green)
2022-08-02 22:12:31,832 # #1	ACT_SWITCH	LD2(blue)
2022-08-02 22:12:31,834 # #2	ACT_SWITCH	LD3(red)
2022-08-02 22:12:31,837 # #3	SENSE_BTN	B1(User button)
2022-08-02 22:12:31,838 # #4	ACT_SERVO	servo
> saul write 4 0
2022-08-02 22:12:41,443 # saul write 4 0
2022-08-02 22:12:41,445 # Writing to device #4 - servo
2022-08-02 22:12:41,447 # Data:	             0 
2022-08-02 22:12:41,450 # [servo] setting 0 to 2949 (0 / 255)
2022-08-02 22:12:41,453 # data successfully written to device #4
> saul write 4 256
2022-08-02 22:12:45,343 # saul write 4 256
2022-08-02 22:12:45,346 # Writing to device #4 - servo
2022-08-02 22:12:45,347 # Data:	           256 
2022-08-02 22:12:45,351 # [servo] setting 0 to 6865 (255 / 255)
2022-08-02 22:12:45,354 # data successfully written to device #4
```

Each write resulted in the MG90S servo that I connected to move to the corresponding position.

### Issues/PRs references

Co-authored-by: Marian Buschsieweke <marian.buschsieweke@ovgu.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Area: doc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MrKevinWeiss @riot-hil-bot