Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEV-52] 외국인 학생 검사 추가 #298

Merged
merged 14 commits into from
Jan 9, 2025
Merged

[DEV-52] 외국인 학생 검사 추가 #298

merged 14 commits into from
Jan 9, 2025

Conversation

k-kbk
Copy link
Collaborator

@k-kbk k-kbk commented Jan 2, 2025

Issue

#296

✅ 작업 내용

  • 외국인 학생 검사
    • 한국어 과목
    • 채플 및 기독교 교양
    • 경영학과 - 외국인 학생 전용 전공

🤔 고민 했던 부분

🔊 도움이 필요한 부분!!

@k-kbk k-kbk added the ✨ feat 새로운 기능 개발 혹은 기존 기능 변경 label Jan 2, 2025
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 52.66667% with 71 lines in your changes missing coverage. Please review.

Project coverage is 80.93%. Comparing base (1c63119) to head (52184f1).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...monculture/CommonCultureDetailCategoryManager.java 41.66% 23 Missing and 5 partials ⚠️
...ion/service/CheckGraduationRequirementService.java 0.00% 13 Missing ⚠️
...n/domain/service/major/MajorGraduationManager.java 30.00% 6 Missing and 1 partial ⚠️
...uate/myongjigraduatebe/user/domain/model/User.java 70.83% 5 Missing and 2 partials ⚠️
...pplication/service/CalculateGraduationService.java 0.00% 6 Missing ⚠️
...dto/request/CheckGraduationRequirementRequest.java 0.00% 3 Missing ⚠️
...aduatebe/graduation/domain/model/ChapelResult.java 0.00% 3 Missing ⚠️
.../graduation/domain/model/DetailCategoryResult.java 0.00% 2 Missing ⚠️
...tion/api/CheckGraduationRequirementController.java 0.00% 1 Missing ⚠️
.../coreculture/CoreCultureDetailCategoryManager.java 66.66% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #298      +/-   ##
=============================================
- Coverage      82.64%   80.93%   -1.71%     
- Complexity       646      657      +11     
=============================================
  Files            161      162       +1     
  Lines           2720     2791      +71     
  Branches         102      114      +12     
=============================================
+ Hits            2248     2259      +11     
- Misses           407      460      +53     
- Partials          65       72       +7     
Files with missing lines Coverage Δ
...service/commonculture/CommonGraduationManager.java 100.00% <100.00%> (ø)
...on/domain/service/major/MandatoryMajorManager.java 100.00% <100.00%> (ø)
...be/lecture/domain/model/CommonCultureCategory.java 100.00% <100.00%> (ø)
...g/application/service/ParsingAnonymousService.java 86.20% <100.00%> (ø)
...user/application/service/signup/SignUpService.java 88.88% <100.00%> (+1.38%) ⬆️
...ervice/update/UpdateStudentInformationService.java 100.00% <100.00%> (ø)
...user/application/usecase/signup/SignUpCommand.java 100.00% <100.00%> (ø)
...e/myongjigraduatebe/user/domain/model/College.java 100.00% <100.00%> (ø)
...ongjigraduatebe/user/domain/model/KoreanLevel.java 100.00% <100.00%> (ø)
...tion/api/CheckGraduationRequirementController.java 0.00% <0.00%> (ø)
... and 9 more

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c63119...52184f1. Read the comment docs.

@k-kbk k-kbk marked this pull request as ready for review January 6, 2025 07:58
@k-kbk k-kbk self-assigned this Jan 6, 2025
Copy link
Member

@stophwan stophwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 확인~!! LGTM~

@github-actions github-actions bot added D-0 and removed D-1 labels Jan 8, 2025
@k-kbk k-kbk merged commit be8850d into develop Jan 9, 2025
4 of 6 checks passed
@k-kbk k-kbk deleted the feature/DEV-52 branch January 9, 2025 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
D-0 ✨ feat 새로운 기능 개발 혹은 기존 기능 변경 size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants