Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Breaking Change] Update return type of get_resource_samples #31

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

[Breaking Change] Update return type of get_resource_samples #31

wants to merge 1 commit into from

Conversation

Mythicaeda
Copy link
Contributor

  • get_resource_samples returns APIResourceSampleResults instead of dict
  • adds optional filter parameter to get_resource_timelines

@Mythicaeda Mythicaeda requested a review from cartermak June 14, 2023 18:36
@Mythicaeda Mythicaeda self-assigned this Jun 14, 2023
@cartermak cartermak added this to the v2 milestone Jun 27, 2023
@cartermak cartermak added enhancement New/improved features and capabilities breaking change Proposal or code break existing interfaces. labels Jun 27, 2023
@cartermak cartermak changed the base branch from main to develop June 27, 2023 23:13
@cartermak cartermak added the DON'T MERGE Don't merge this yet! label Jun 28, 2023
@cartermak cartermak removed the DON'T MERGE Don't merge this yet! label Jul 11, 2023
@cartermak cartermak force-pushed the allow-filtering-get-resource branch from e1fef30 to 3cd59a3 Compare August 31, 2023 01:22
@cartermak cartermak had a problem deploying to integration-test-workflow August 31, 2023 01:23 — with GitHub Actions Failure
@cartermak cartermak had a problem deploying to integration-test-workflow August 31, 2023 01:23 — with GitHub Actions Error
@cartermak cartermak had a problem deploying to integration-test-workflow August 31, 2023 01:23 — with GitHub Actions Error
@cartermak cartermak had a problem deploying to integration-test-workflow August 31, 2023 01:23 — with GitHub Actions Failure
@cartermak cartermak had a problem deploying to integration-test-workflow August 31, 2023 01:23 — with GitHub Actions Error
@cartermak cartermak had a problem deploying to integration-test-workflow August 31, 2023 01:23 — with GitHub Actions Error
@cartermak cartermak had a problem deploying to integration-test-workflow August 31, 2023 01:23 — with GitHub Actions Failure
@cartermak cartermak had a problem deploying to integration-test-workflow August 31, 2023 01:23 — with GitHub Actions Error
@cartermak cartermak had a problem deploying to integration-test-workflow August 31, 2023 01:23 — with GitHub Actions Error
@cartermak cartermak had a problem deploying to integration-test-workflow August 31, 2023 01:23 — with GitHub Actions Error
@cartermak cartermak had a problem deploying to integration-test-workflow August 31, 2023 01:23 — with GitHub Actions Failure
@cartermak cartermak had a problem deploying to integration-test-workflow August 31, 2023 01:23 — with GitHub Actions Error
@Mythicaeda @cartermak
[Breaking Change] get_resource_samples returns `APIResourceSampleRe…
7b2c49b 
…sults` instead of dict

Additionally, add optional filter parameter to `get_resource_timelines`
@cartermak cartermak force-pushed the allow-filtering-get-resource branch from 3cd59a3 to 7b2c49b Compare September 7, 2023 00:06
@cartermak cartermak had a problem deploying to integration-test-workflow September 7, 2023 00:06 — with GitHub Actions Error
@cartermak cartermak had a problem deploying to integration-test-workflow September 7, 2023 00:06 — with GitHub Actions Failure
@cartermak cartermak had a problem deploying to integration-test-workflow September 7, 2023 00:06 — with GitHub Actions Error
@cartermak cartermak had a problem deploying to integration-test-workflow September 7, 2023 00:06 — with GitHub Actions Error
@cartermak cartermak had a problem deploying to integration-test-workflow September 7, 2023 00:06 — with GitHub Actions Error
@cartermak cartermak had a problem deploying to integration-test-workflow September 7, 2023 00:06 — with GitHub Actions Error
@cartermak cartermak had a problem deploying to integration-test-workflow September 7, 2023 00:06 — with GitHub Actions Error
@cartermak cartermak had a problem deploying to integration-test-workflow September 7, 2023 00:06 — with GitHub Actions Failure
@cartermak cartermak modified the milestones: v2, v3 Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cartermak cartermak Awaiting requested review from cartermak

At least 1 approving review is required to merge this pull request.

Assignees

@Mythicaeda Mythicaeda

Labels
breaking change Proposal or code break existing interfaces. enhancement New/improved features and capabilities
Projects
None yet
Milestone
v3
Development

Successfully merging this pull request may close these issues.
2 participants
@Mythicaeda @cartermak