Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: converts to ESM package #52

Merged
merged 6 commits into from
Oct 25, 2024
Merged

feat: converts to ESM package #52

merged 6 commits into from
Oct 25, 2024

Conversation

elliotBraem
Copy link
Contributor

@elliotBraem elliotBraem commented Oct 20, 2024

Description

This package is currently exposing only CommonJS, this pull-request introduces tsup and now builds for both CommonJS and ESM.

As part of this, I've replaced most all instances of "near-api-js" with the esm alternatives @near-js

Type of change

  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 🏗️ Build configuration (CI configuration, scaffolding etc.)
  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • 📝 Documentation update(s)
  • 📦 Dependency update(s)
  • 👩🏽‍💻 Improve developer experience
  • ⚡ Improve performance
  • ✨ New feature (non-breaking change which adds functionality)
  • ♻ Refactor
  • ⏪ Revert changes
  • 🧪 New tests or updates to existing tests

@jaswinder6991
Copy link
Collaborator

Hi @elliotBraem thanks for the thoughtful contribution. Everything looks good to me. Although I am not much experienced with the whole ESM package thingy. I will take out sometime to learn what exactly is happening.
Feel free to merge the PR though.

The only open question I have is about docs, why did we remove the TS, JS with CDN, JS tabs to replace with just simple JS example?
Is that something because of ESM?

@elliotBraem elliotBraem merged commit 741193b into beta Oct 25, 2024
5 checks passed
@elliotBraem elliotBraem deleted the feat/esm branch October 25, 2024 02:06
github-actions bot pushed a commit that referenced this pull request Oct 25, 2024
# [1.1.0-beta.6](v1.1.0-beta.5...v1.1.0-beta.6) (2024-10-25)

### Features

* converts to ESM package ([#52](#52)) ([741193b](741193b))
@kieranroneill
Copy link
Collaborator

🎉 This PR is included in version 1.1.0-beta.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

@kieranroneill kieranroneill added the 🚀 released To the moon! label Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚀 released To the moon!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants