Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1 Land Use Change #1040

Merged
merged 132 commits into from
Dec 19, 2023

rename the patch paramfile for api 32

7a7a8a3
Select commit
Loading
Failed to load commit list.
Merged

v1 Land Use Change #1040

rename the patch paramfile for api 32
7a7a8a3
Select commit
Loading
Failed to load commit list.
Task list completed / task-list-completed succeeded Dec 19, 2023 in 0s

7 / 7 tasks completed

All tasks have been completed

Details

Required Tasks

Task Status
E3SM pull request: E3SM-Project/E3SM#5760 Incomplete
CTSM pull request: ESCOMP/CTSM#2076 Incomplete
extending land use change to nocomp logic (where both land use and land cover need to be jointly specified). Incomplete
treatment of a simplified crop PFT on croplands. Incomplete
grazing and/or fire management on pasture, rangeland, and croplands. Incomplete
other management approaches that govern land cover as a function of land use when not using nocomp configurations. Incomplete
consolidating the drivers of logging from their current location in the surface dataset into the FATES-LUH2 dataset (where both area-based and mass-based driving data currently now also exists) Incomplete
My change requires a change to the documentation. Completed
I have updated the in-code documentation .AND. (the technical note .OR. the wiki) accordingly. Completed
I have read the CONTRIBUTING document. Completed
FATES PASS/FAIL regression tests were run Completed
If answers were expected to change, evaluation was performed and provided Completed
Addition of a grazing (and, in principle, browsing) module as an initial set of land use practices on pasture and rangeland patches: ckoven/fates@luh2...ckoven:fates:grazing_merge Incomplete
Logic to handle the intersection of land use change and prescribed land cover (both for nocomp cases on all land use types, and for full-fates cases on crop land use types): ckoven/fates@luh2...ckoven:fates:luh2_nocomp_merge Incomplete
We should move the currently-hard-coded parameters that define what fraction of woody biomass gets turned into product pools and what fraction of leaf biomass gets burned during any given land-use transition with clearing to the parameter file. We may also want to make them PFT-dependent. See here: https://github.com/NGEET/fates/pull/1040/files#diff-28c679efbe804905b8b4fac3ccdbb04f6bb3bcd2794fe1a4556d5541e008a750R2153-R2154 Incomplete
There are two problems with the clearing ruleset logic; one is that there is a logic error for ruleset number one that needs to be fixed, and two is that we should switch the default behavior to the ruleset four (always clear transitions to pasture and crop, never to rangeland) as the simplest case to start with. Completed
consolidate the new parameters that are max patches for each land use type. instead of a bunch of scalar parameters, this would be better as a vector of length equal to the number of land-use types. Completed