-
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix aspa migration issues #1163
Conversation
@ximon18 improved the tests and fixed an issue so that 0.9.6 can be upgraded. Incidentally, 0.9.6 cannot be upgraded to 0.10.x if it has ASPA. But it can be upgraded to 0.14.3 (when this is merged and released). |
When you say "cannot" - what happens if someone tries? |
If people used ASPA in 0.9.x, they can only upgrade to 0.14.3. This was not working in past versions. If they did not use ASPA, then they could have updated to 0.10.x and above. I tested that upgrades with ASPA from 0.10.3 to 0.11.0 to 0.12.1 to 0.13.1 work, and used the data dir after each of those upgrades in automated tests for upgrading to 0.14.3. I can manually test that on the test machine when I have a package for this PR. |
* Pre 0.14.x AspaDefinitionUpdates also used plain Asn for "remove" * Fix handling of skipped ASPA migration commands, and ASPA events in other commands. * Fix upgraded for 0.9.6 (and use better testdata) * Improve test data
No description provided.