Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use dependency versions that cause warnings. #1174

Merged
merged 3 commits into from
Dec 13, 2023
Merged

Don't use dependency versions that cause warnings. #1174

merged 3 commits into from
Dec 13, 2023

Conversation

ximon18
Copy link
Member

@ximon18 ximon18 commented Dec 13, 2023 •
edited
Loading

This PR fixes issue #1173.

@ximon18 ximon18 requested a review from timbru December 13, 2023 10:11
@ximon18 ximon18 force-pushed the dont-lock-to-yanked-dependency-versions branch from 47fe5b4 to 534722b Compare December 13, 2023 10:16
Base automatically changed from upgrade-kvx-for-1171 to prep-0.14.4 December 13, 2023 10:22
@ximon18 ximon18 linked an issue Dec 13, 2023 that may be closed by this pull request
Documented cargo install command prints warnings about yanked versions. #1173
Closed
@ximon18 ximon18 force-pushed the dont-lock-to-yanked-dependency-versions branch from 534722b to 37ad474 Compare December 13, 2023 10:29
@ximon18
Copy link
Member Author

ximon18 commented Dec 13, 2023 •
edited
Loading

cargo update -p deunicode chose version 0.4.5 but frustratingly there is no tag for the new version in the deunicode Git repository :-( See: kornelski/deunicode@v0.4.3...v0.4.5

@ximon18
Copy link
Member Author

ximon18 commented Dec 13, 2023 •
edited
Loading

Looking into the source code of the 0.4.5 deunicode crate it has a .cargo_vcs_info.json file that refers to Git rev 7b5b296449d8481654dfc3d03fd7ede949bcc582. A diff of that rev compared to v0.4.3 seems to be empty.

@ximon18 ximon18 changed the title Don't use dependency versions that cause warnings (fixes #1173) Don't use dependency versions that cause warnings. Dec 13, 2023
@ximon18
Copy link
Member Author

ximon18 commented Dec 13, 2023

The differences in the hermit-abi crate dependency version compared to the new one chosen by cargo update -p hermit-abi@v0.3.1 are quite large. Unfortunately there is no GH release or changelog content I can see that summarizes it or points out what if anything is actually important.

@ximon18 ximon18 merged commit 6a9c779 into prep-0.14.4 Dec 13, 2023
18 checks passed
@ximon18 ximon18 deleted the dont-lock-to-yanked-dependency-versions branch December 13, 2023 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@partim partim partim approved these changes

@timbru timbru Awaiting requested review from timbru

Assignees
No one assigned
Labels
None yet
Projects
0.14.x
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documented cargo install command prints warnings about yanked versions.
2 participants
@ximon18 @partim