Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add variable summing and PM unit conversions for firexaq dataset #255

Merged
merged 4 commits into from
Jul 19, 2024

Conversation

colin-harkins
Copy link
Collaborator

@colin-harkins colin-harkins commented Mar 27, 2024

This pull request adds the functionality for summing up variables into a new variable for models and obs. An example of how this is used is that model PM variables may need to be summed when comparing to observational variables for PM.

Additionally, this pull requests adds functions for some of the unit conversions between std and amb needed to compare with variables in firexaq.

This is developed based on the code attached below.

analysis_LA_both_aerosols_vert_mix_v422_phot.txt

@colin-harkins colin-harkins requested review from qdzhu and rschwant March 27, 2024 22:58
@rschwant rschwant requested a review from quaz115 April 8, 2024 17:08
@rschwant
Copy link
Collaborator

@colin-harkins
This looks great Colin! I just have a couple very small changes.

I realized that the units in your example for the BC are in ng instead of ug. So can you add the following change in the example yaml file:

'BC_mass_90_550_nm_SCHWARZ':
unit_scale: 1000. #Opt Scaling factor
unit_scale_method: '/' #Opt Multiply = '*' , Add = '+', subtract = '-', divide = '/'

And then I also realized that the example WRF-Chem file you and Quazi are using is an intermediate WRF-Chem simulation of the RACM2B-VCP mechanism that has very low OA and maybe some other problems too. Best to use a more standard file, so can you update to use these files instead (I believe these are the vertical data for the surface data that is now on the ftp site for the auto examples in MELODIES MONET): /wrk/d2/rschwantes/wrf/firex_mech/wrfchem_example/racm_esrl/*

Then the organic aerosol much more closely aligns with what my previous script got, which is a great QC of all of this. I tested these updates and they should work well, but let me know if you run into problems.

Everything else looks great!

@colin-harkins
Copy link
Collaborator Author

@rschwant I made the changes you requested, if you're able to approve this I'll merge it in.

Copy link
Collaborator

@rschwant rschwant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, feel free to merge in when you have the chance. Thanks!

@colin-harkins colin-harkins merged commit db7917c into NOAA-CSL:develop Jul 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants