Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dev/ufs-weather-model with develop 2024-01-16 #1343

Open
wants to merge 30 commits into
base: dev/ufs-weather-model
Choose a base branch
from
Open

Update dev/ufs-weather-model with develop 2024-01-16 #1343

wants to merge 30 commits into from
+1,799 −305

Conversation

JessicaMeixner-NOAA
Copy link
Collaborator

@JessicaMeixner-NOAA JessicaMeixner-NOAA commented Jan 6, 2025 •
edited
Loading

Pull Request Summary

Update dev/ufs-weather-model with develop 2024-01-16

Description

Update dev/ufs-weather-model with develop 2024-01-16

Note this changes baselines in ufs-weather-model. This is not anticipated but after a lot of searching could not find the reason. The differences are small and we replicate results after the fact.

To be opened after #1342 is merged.

Issue(s) addressed

  • no issue

Commit Message

Update dev/ufs-weather-model with develop 2024-1-16

Check list

Testing

  • How were these changes tested? within ufs-weather-model. Update WW3 with 20240116 commit  ufs-community/ufs-weather-model#2550
  • Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
  • Have the matrix regression tests been run (if yes, please note HPC and compiler)?
  • Please indicate the expected changes in the regression test output, (Note the list of known non-identical tests.)
  • Please provide the summary output of matrix.comp (matrix.Diff.txt, matrixCompFull.txt and matrixCompSummary.txt):

mickaelaccensi and others added 28 commits July 31, 2023 11:38
@mickaelaccensi
minor bugfix for matrix grepping on keywords (NOAA-EMC#1049)
1cacc43
@benoitp-cmc
Stop masking group 1 output where icec > icen (NOAA-EMC#1019)
dcafc8c
@MatthewMasarik-NOAA
Doxygen documentation added, 8th subset.(NOAA-EMC#1046)
2715a9e
@Ghazal-Mohammadpour
NC4 ,F90 ,XX0 switches removed from ww3_tp2.19 regtest (NOAA-EMC#1054)
b810a89
@MatthewMasarik-NOAA
CI: Fix for Intel scripts. GNU scripts updated. (NOAA-EMC#1064)
991daf8
@mickaelaccensi
correct the computation of QP parameter, add QKK output parameter, ch…
6b9edfa 
…ange UST scale factor (NOAA-EMC#1050)
@mickaelaccensi
correct issue with ww3_multi when requesting restart2 and using nml f…
8589d12 
…ile instead of inp file (NOAA-EMC#1070)
@mickaelaccensi
correct calendar for track netcdf output (NOAA-EMC#1079)
7bbdaca
@ukmo-ccbunney
Fix missing mod_def.ww3 file in multigrid regression tests for track …
b1356dd 
…output (NOAA-EMC#1091)
@MatthewMasarik-NOAA
STAB3: fix cmake build for ST4 or ST3 (NOAA-EMC#1086)
d22b7bb
@mickaelaccensi
new feature to output out_grd.ww3, out_pnt.ww3 and mod_def.ww3 both i…
eff6686 
…n binary and ascii format using switch ASCII. (NOAA-EMC#1089)
@ukmo-ccbunney
Update local unit number arrays (NDS, MDS) to be same size of array d…
d148d09 
…efined in w3odatmd (size=15). Also, defined unit numbers for NDS(14) and NDS(15). (NOAA-EMC#1098)
@ukmo-ccbunney
Removed code referencing PHIOC in output section for PHICE in ww3_ounf (
66262f6 
NOAA-EMC#1093)
@mickaelaccensi
implementation of the GQM (Gaussian Quadrature Method) to replace the…
8eb3596 
… DIA in NL1 or NL2. (NOAA-EMC#1083)
@JessicaMeixner-NOAA
update logic to ensure you are not accessing uninitialized dates (NOA…
4cd995d 
…A-EMC#1114)
@ukmo-ccbunney
Initialised S and D arrays in W3SDB1 before potential early return if…
c3451a9 
… zero energy. (NOAA-EMC#1115)
@Biao-Zhao
ww3_ounp.F90: x/y units attribute corrected from 'm' to 'km' (NOAA-EM…
f702a8f 
…C#1088)
@ukmo-ccbunney
Bugfix: Assign unit numbers to ASCII gridded/point output in multi-gr…
1f928aa 
…id mode. (NOAA-EMC#1118)
@mickaelaccensi
correct bugs to run correctly GQM implementation (NOAA-EMC#1127)
d90078b
@edwardhartnett
Adding documentation to w3iopo() in preparation for code for NOAA-EMC…
3f35df7 
…#682. (NOAA-EMC#1131)
@MatthewMasarik-NOAA
NCEP regtest module updates: uses spack-stack/1.5.0, includes scotch/…
ff1b9e9 
…7.0.4 (NOAA-EMC#1137)
@JessicaMeixner-NOAA
Minor update to ncep regtests (NOAA-EMC#1138)
d3ea810
@edwardhartnett
Updated intel workflow to install oneapi compilers from new location. (…
88c89be 
…NOAA-EMC#1157)
@edwardhartnett
Add unit test for points I/O code. (NOAA-EMC#1158)
7bec560
@AlexanderRichert-NOAA
Update Intel CI (relocate /usr/local; ensure intel-oneapi-mpi; use ub…
63f8270 
…untu-latest) (NOAA-EMC#1161)
@JessicaMeixner-NOAA
Merge branch 'WW3develop20240111' into devufs20241211develop20240111
2e49d78 
 Conflicts:
	.github/workflows/intel.yml
	model/src/w3initmd.F90
	model/src/w3iogomd.F90
	model/src/w3ounfmetamd.F90
@JessicaMeixner-NOAA
update mds 13->15
174cf7b
@mickaelaccensi @JessicaMeixner-NOAA
remove lookup table for ST4 to speed up computation and clean up the …
2f01632 
…ST4 code (NOAA-EMC#1124)

Co-authored-by: Fabrice Ardhuin <fabrice.ardhuin@ifremer.fr>
@JessicaMeixner-NOAA JessicaMeixner-NOAA marked this pull request as ready for review January 6, 2025 20:48
@JessicaMeixner-NOAA JessicaMeixner-NOAA mentioned this pull request Jan 6, 2025
Open
15 tasks
@JessicaMeixner-NOAA
Copy link
Collaborator Author

Changes should now be seen as just those in: 3952826

@JessicaMeixner-NOAA
Copy link
Collaborator Author

UFS test logs: https://github.com/ufs-community/ufs-weather-model/blob/176ff22243f8fd8367601d99d3d3ef0d79427292/tests/logs/RegressionTests_hera.log

@jkbk2004
Copy link

@MatthewMasarik-NOAA Can you review this pr? This pr has been combined to ufs-community/ufs-weather-model#2387

@MatthewMasarik-NOAA
Copy link
Collaborator

@MatthewMasarik-NOAA Can you review this pr? This pr has been combined to ufs-community/ufs-weather-model#2387

@jkbk2004 I'm currently reviewing. I had found one difference in the test_changes.list from @JessicaMeixner-NOAA's and was looking into that.

cpld_control_pdlib_p8_gnu failed for me as 'unable to complete comparison'. @JessicaMeixner-NOAA should this just be added to the list of failed tests, or let me know if there is some other way you'd like to proceed?

@jkbk2004
Copy link

@MatthewMasarik-NOAA Can you review this pr? This pr has been combined to ufs-community/ufs-weather-model#2387

@jkbk2004 I'm currently reviewing. I had found one difference in the test_changes.list from @JessicaMeixner-NOAA's and was looking into that.

cpld_control_pdlib_p8_gnu failed for me as 'unable to complete comparison'. @JessicaMeixner-NOAA should this just be added to the list of failed tests, or let me know if there is some other way you'd like to proceed?

@MatthewMasarik-NOAA sounds like we need new baseline for the case. If that's only issue, we can start working on this pr.

MatthewMasarik-NOAA
MatthewMasarik-NOAA approved these changes Jan 22, 2025
View reviewed changes
Copy link
Collaborator

@MatthewMasarik-NOAA MatthewMasarik-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review
Pass

Testing
Pass

OK given by @jkbk2004 for cpld_control_pdlib_p8_gnu needing a new baseline.
test_changes.list.txt
RegressionTests_hera.log.txt

@JessicaMeixner-NOAA JessicaMeixner-NOAA mentioned this pull request Jan 22, 2025
Open
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatthewMasarik-NOAA MatthewMasarik-NOAA MatthewMasarik-NOAA approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@JessicaMeixner-NOAA @jkbk2004 @MatthewMasarik-NOAA @mickaelaccensi @benoitp-cmc @Ghazal-Mohammadpour @ukmo-ccbunney @Biao-Zhao @edwardhartnett @AlexanderRichert-NOAA