Enable GCF loader to filter singleton GCFs #179
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add keep_singleton to the base class of GCF loader
|
The refactoring of whole loading pipeline will have a series of dependent PRs (a PR depends on its former PR). To make sure that I don't have to start the next PR after the review and approval of its former PR, I'm going to try the so-called "stacked PR" workflow. For that, I'm going to use the tool Graphite to manage PRs. As a reviewer (@gcroci2), you don't need to do anything. Just review the PR in the same way as what you did before. This PR will be closed and a same PR (#181) is created by Graphite. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new parameter
keep_singletonin the methodget_gcfs()of GCF loader. With that, users can choose to keep the singleton GCFs (A GCF that contains only one BGC member) or not in the loading process.