Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecate the method _load_class_info #198

Merged
merged 3 commits into from
Jan 24, 2024
Merged

deprecate the method _load_class_info #198

merged 3 commits into from
Jan 24, 2024

Conversation

CunliangGeng
Copy link
Member

@CunliangGeng CunliangGeng commented Dec 12, 2023 •
edited
Loading

Deprecate the method _load_class_info at the moment (these annotations data is not needed now). The method requires refactoring, but we will do it when handling annotations.

ℹ️ To refactor the following when dealing with annotations:

  • running of CANOPUS to predict chemical classes
  • loading chemical classes to annotate spectra and molecular families

This was referenced Dec 12, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Merged
@CunliangGeng Graphite App
Copy link
Member Author

CunliangGeng commented Dec 12, 2023 •
edited
Loading

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

This was referenced Dec 12, 2023
Merged
Merged
Merged
@CunliangGeng CunliangGeng requested a review from gcroci2 December 12, 2023 15:37
@CunliangGeng CunliangGeng force-pushed the 12-11-update_loading_genomics branch from ede6a9a to ed4d425 Compare December 14, 2023 08:33
@CunliangGeng CunliangGeng force-pushed the 12-12-deprecate_loading_chemical_classes branch from 06340eb to e164eaa Compare December 14, 2023 08:33
@CunliangGeng CunliangGeng force-pushed the 12-11-update_loading_genomics branch from ed4d425 to 36816a7 Compare December 14, 2023 10:00
@CunliangGeng CunliangGeng force-pushed the 12-12-deprecate_loading_chemical_classes branch from e164eaa to a0410ca Compare December 14, 2023 10:00
@CunliangGeng CunliangGeng force-pushed the 12-11-update_loading_genomics branch from 36816a7 to bc05232 Compare December 19, 2023 13:21
@CunliangGeng CunliangGeng force-pushed the 12-12-deprecate_loading_chemical_classes branch from a0410ca to 42793a8 Compare December 19, 2023 13:21
@CunliangGeng CunliangGeng force-pushed the 12-11-update_loading_genomics branch from bc05232 to 83f8e39 Compare December 19, 2023 13:38
@CunliangGeng CunliangGeng force-pushed the 12-12-deprecate_loading_chemical_classes branch from 42793a8 to ecb03e8 Compare December 19, 2023 13:38
This was referenced Dec 20, 2023
Merged
Merged
gcroci2
gcroci2 approved these changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@gcroci2 gcroci2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess these few changes are not very meaningful now, but will be

@CunliangGeng
Copy link
Member Author

I guess these few changes are not very meaningful now, but will be

you're right. Deprecating them instead of removing will make it easier for refactoring later ;-)

@CunliangGeng Graphite App
Copy link
Member Author

CunliangGeng commented Jan 24, 2024 •
edited
Loading

Merge activity

@CunliangGeng CunliangGeng force-pushed the 12-11-update_loading_genomics branch from 83f8e39 to c3bc259 Compare January 24, 2024 15:21
Base automatically changed from 12-11-update_loading_genomics to dev January 24, 2024 15:22
@CunliangGeng
deprecate the method _load_class_info
76db23c 
To refactor the following when dealing with annotations:
- running of CANOPUS to predict chemical classes
- loading chemical classes to annotate spectra and moleclar families
@CunliangGeng
add explicit attribute self.chem_classes
d085aec 
add explicit attribute `self.chem_classes` to make class `NPLinker` workable.
@CunliangGeng
add explicit attribute self. class_matches
b714bed 
add explicit attribute `self.cless_matches` to make class `NPLinker` workable.
@CunliangGeng CunliangGeng force-pushed the 12-12-deprecate_loading_chemical_classes branch from 262b6b5 to b714bed Compare January 24, 2024 15:23
@CunliangGeng CunliangGeng merged commit c4f6687 into dev Jan 24, 2024
1 of 2 checks passed
@CunliangGeng CunliangGeng deleted the 12-12-deprecate_loading_chemical_classes branch January 24, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gcroci2 gcroci2 gcroci2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CunliangGeng @gcroci2