Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add gnps version as a new setting in config file #291

Merged
merged 4 commits into from
Jan 20, 2025
Merged

add gnps version as a new setting in config file #291

merged 4 commits into from
Jan 20, 2025
+24 −0

Conversation

CunliangGeng
Copy link
Member

@CunliangGeng CunliangGeng commented Jan 10, 2025 •
edited
Loading

To support GNPS2 (https://gnps2.org/) data in NPLinker, we have to add a new setting gnps.version in the config file nplinker.toml.

@CunliangGeng Graphite App
Copy link
Member Author

CunliangGeng commented Jan 10, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Jan 10, 2025
Merged
Merged
Merged
Merged
Merged
@CunliangGeng CunliangGeng force-pushed the add_gnps_version_to_config_file branch from 5bcd64e to c14bbc1 Compare January 10, 2025 15:34
@CunliangGeng CunliangGeng requested a review from gcroci2 January 10, 2025 15:41
@CunliangGeng CunliangGeng marked this pull request as ready for review January 10, 2025 15:41
@CunliangGeng CunliangGeng self-assigned this Jan 10, 2025
@CunliangGeng Graphite App
Copy link
Member Author

CunliangGeng commented Jan 20, 2025 •
edited
Loading

Merge activity

  • Jan 20, 10:36 AM EST: A user started a stack merge that includes this pull request via Graphite.
  • Jan 20, 10:41 AM EST: Graphite rebased this pull request as part of a merge.
  • Jan 20, 10:42 AM EST: A user merged this pull request with Graphite.

@CunliangGeng CunliangGeng changed the base branch from change_bigscape_version_settings_to_str to graphite-base/291 January 20, 2025 15:38
@CunliangGeng CunliangGeng changed the base branch from graphite-base/291 to dev January 20, 2025 15:39
@CunliangGeng CunliangGeng force-pushed the add_gnps_version_to_config_file branch from c14bbc1 to cda2c90 Compare January 20, 2025 15:40
@CunliangGeng CunliangGeng merged commit 07e750c into dev Jan 20, 2025
3 checks passed
@CunliangGeng CunliangGeng deleted the add_gnps_version_to_config_file branch January 20, 2025 15:42
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gcroci2 gcroci2 gcroci2 approved these changes

Assignees

@CunliangGeng CunliangGeng

Labels
None yet
Projects
dev
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CunliangGeng @gcroci2